Refactor Players 3/12: Add player layout helper#1286
Open
dgruss wants to merge 1 commit into
Open
Conversation
dgruss
changed the title
dgruss
force-pushed
the
refactorplayers-12-03-player-layout-helper
branch
from
9627f51 to
9f259d0
Compare
Contributor
Author
|
made this one independent of #1285 |
dgruss
force-pushed
the
refactorplayers-12-03-player-layout-helper
branch
from
9f259d0 to
5c60c64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1186.
Files changed in this PR:
This introduces the shared layout helper that calculates player slots/rectangles. It prepares later screen migrations by moving layout rules into one place instead of duplicating placement logic per screen.
There is no user-facing / visual change anywhere from this PR - it is only adding a class that will be used later on.
(The complete chain fixes #634. Fixes #545. Fixes #732. Fixes #712.)