Refactor Players 4/12: Load generic player layout templates from themes#1287
Draft
dgruss wants to merge 4 commits into
Draft
Refactor Players 4/12: Load generic player layout templates from themes#1287dgruss wants to merge 4 commits into
dgruss wants to merge 4 commits into
Conversation
dgruss
changed the title
This was referenced May 12, 2026
dgruss
force-pushed
the
refactorplayers-12-04-theme-layout-support
branch
from
d895cb5 to
14b179d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1186. Builds on #1286.
Files changed in this PR:
This extends UThemes so screens can load and access the new generic player templates. It prepares the player selection, song, score, and sing screen migrations.
The old theme elements are still used, so there is no user-facing / visual change anywhere from this PR - it is only preparing the theme loading part.