Skip to content
This repository was archived by the owner on May 11, 2025. It is now read-only.

Add menu bar#571

Open
cuba wants to merge 2 commits into
Whisky-App:mainfrom
cuba:uplift/menu-toolbar
Open

Add menu bar#571
cuba wants to merge 2 commits into
Whisky-App:mainfrom
cuba:uplift/menu-toolbar

Conversation

@cuba

@cuba cuba commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

I think it would be really nice to add a menu bar so that we can close the Whisky window and still have its applications running or access certain useful tools.

I have created this POC for your consideration. Changes include

  1. Closing window no longer terminates the application
  2. Can perform some common commands right from the menu bar without having the application in focus
  3. Uses pure vanilla SwiftUI components
Screenshot 2023-11-03 at 1 27 15 AM

@IsaacMarovitz

Copy link
Copy Markdown
Member

I like the concept! Looks like it could be helpful

@cuba

cuba commented Oct 29, 2023

Copy link
Copy Markdown
Contributor Author

I like the concept! Looks like it could be helpful

Glad you like the concept! I can develop it further if you think it's worthwhile. I don't think it should become too bloated because it should just perform some of the most common functionality. But feel free to put any comments or suggestions in code or here where you would like to see this go, the file organization, etc when you can.

So if we're in agreement, I'd like to take this further I'll have to touch some more of your written code just so the menu bar and the application stays in sync because I don't think they do right now.

@cuba cuba force-pushed the uplift/menu-toolbar branch 2 times, most recently from faf541d to ee5cf38 Compare November 1, 2023 05:15
@IsaacMarovitz

Copy link
Copy Markdown
Member

@cuba Rebase needed after recent reorganisation

@cuba cuba force-pushed the uplift/menu-toolbar branch from ee5cf38 to 79ba9e3 Compare November 3, 2023 07:26
@cuba

cuba commented Nov 3, 2023

Copy link
Copy Markdown
Contributor Author

@cuba Rebase needed after recent reorganisation

Done, I had to rebase it on my newer settings fixes PR so that the changes in the menu bar / in the app are in sync. Added icons to pinned items as well

@cuba cuba changed the title [POC] Add menu bar Add menu bar Nov 3, 2023
@cuba cuba force-pushed the uplift/menu-toolbar branch 2 times, most recently from 8a09e71 to c658094 Compare November 10, 2023 06:41
@cuba cuba force-pushed the uplift/menu-toolbar branch from c658094 to b4a7694 Compare November 23, 2023 05:10
@cuba cuba force-pushed the uplift/menu-toolbar branch from b4a7694 to 4304725 Compare November 27, 2023 01:18
@itjustcrashed

Copy link
Copy Markdown

Is this commit stale?

frankea added a commit to frankea/Whisky that referenced this pull request Jun 13, 2026
Adds an opt-in menu-bar item (Settings → General → "Show Whisky in the menu
bar", off by default). When enabled it lets you launch a bottle's pinned
programs, reopen Whisky, or quit without the main window focused — and keeps
Whisky running after the window is closed so the menu bar stays reachable and
Wine processes keep running. When disabled, behaviour is unchanged (no menu
bar item, quit on last window close).

Closes Whisky-App#571.
frankea added a commit to frankea/Whisky that referenced this pull request Jun 13, 2026
Adds an opt-in menu-bar item (Settings → General → "Show Whisky in the menu
bar", off by default). When enabled it lets you launch a bottle's pinned
programs, reopen Whisky, or quit without the main window focused — and keeps
Whisky running after the window is closed so the menu bar stays reachable and
Wine processes keep running. When disabled, behaviour is unchanged (no menu
bar item, quit on last window close).

Closes Whisky-App#571.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants