Skip to content

Remove unnecessary boost::system requirement for NuDB#34

Merged
bthomee merged 4 commits intomasterfrom
bthomee/nudb
Jan 26, 2026
Merged

Remove unnecessary boost::system requirement for NuDB#34
bthomee merged 4 commits intomasterfrom
bthomee/nudb

Conversation

@bthomee
Copy link

@bthomee bthomee commented Jan 23, 2026

The NuDB recipe will not build when using Boost 1.89+ as boost::system is no longer there, and has actually not even been needed since Boost 1.69. See also conan-io#28808.

This change, therefore, removes that requirement from NuDB's conanfile.py. Local testing with xrpld shows that the compilation succeeds.

@bthomee bthomee requested a review from mathbunnyru January 23, 2026 18:14
Copy link
Collaborator

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
  2. Please, upstream this change

@bthomee
Copy link
Author

bthomee commented Jan 26, 2026

  1. Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
  2. Please, upstream this change
  1. I'll do that.
  2. There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.

@bthomee bthomee requested a review from mathbunnyru January 26, 2026 13:23
@bthomee
Copy link
Author

bthomee commented Jan 26, 2026

  1. Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
  2. Please, upstream this change
  1. I'll do that.
  2. There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.

btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.

@mathbunnyru
Copy link
Collaborator

mathbunnyru commented Jan 26, 2026

  1. Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
  2. Please, upstream this change
  1. I'll do that.
  2. There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.

btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.

  1. Let's bump to 1.90, maybe we won't need to force boost version, which is also nice.
  2. I would certainly like to decrease the maintenance effort of this repo and make it easier for 3rd party contributors to contribute. To achieve that, we need to gradually upstream our changes.

@bthomee
Copy link
Author

bthomee commented Jan 26, 2026

  1. Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
  2. Please, upstream this change
  1. I'll do that.
  2. There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.

btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.

  1. Let's bump to 1.90, maybe we won't need to force boost version, which is also nice.
  2. I would certainly like to decrease the maintenance effort of this repo and make it easier for 3rd party contributors to contribute. To achieve that, we need to gradually upstream our changes.

To upstream these changes, I doubt that the maintainers of CCI would like the Boost version bump though, since it isn't a necessary change.

@mathbunnyru
Copy link
Collaborator

  1. Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
  2. Please, upstream this change
  1. I'll do that.
  2. There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.

btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.

  1. Let's bump to 1.90, maybe we won't need to force boost version, which is also nice.
  2. I would certainly like to decrease the maintenance effort of this repo and make it easier for 3rd party contributors to contribute. To achieve that, we need to gradually upstream our changes.

To upstream these changes, I doubt that the maintainers of CCI would like the Boost version bump though, since it isn't a necessary change.

A few years ago, they easily accepted version changes, given something else changed as well.
Not sure what the policy right now is.

@bthomee bthomee merged commit 263dd4e into master Jan 26, 2026
1 check passed
@bthomee bthomee deleted the bthomee/nudb branch January 26, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants