You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The NuDB recipe will not build when using Boost 1.89+ as boost::system is no longer there, and has actually not even been needed since Boost 1.69. See also conan-io#28808.
This change, therefore, removes that requirement from NuDB's conanfile.py. Local testing with xrpld shows that the compilation succeeds.
Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
Please, upstream this change
I'll do that.
There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.
Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
Please, upstream this change
I'll do that.
There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.
btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.
Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
Please, upstream this change
I'll do that.
There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.
btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.
Let's bump to 1.90, maybe we won't need to force boost version, which is also nice.
I would certainly like to decrease the maintenance effort of this repo and make it easier for 3rd party contributors to contribute. To achieve that, we need to gradually upstream our changes.
Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
Please, upstream this change
I'll do that.
There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.
btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.
Let's bump to 1.90, maybe we won't need to force boost version, which is also nice.
I would certainly like to decrease the maintenance effort of this repo and make it easier for 3rd party contributors to contribute. To achieve that, we need to gradually upstream our changes.
To upstream these changes, I doubt that the maintainers of CCI would like the Boost version bump though, since it isn't a necessary change.
Let's bump boost version as well, to keep the recipe up-to-date and build-able by default.
Please, upstream this change
I'll do that.
There are too many hoops to jump through, with signing developer license and whatnot, so I'm not really interested. If they want my changes they've got to make things easier.
btw regarding 1, NuDB is buildable by default with Boost 1.83, so bumping the version isn't really required. It's just that they kept boost::system as a requirement when that was unnecessary. I bumped it to 1.89 in any case; I can bump it to 1.90 too, which is what we'll use in xrpld.
Let's bump to 1.90, maybe we won't need to force boost version, which is also nice.
I would certainly like to decrease the maintenance effort of this repo and make it easier for 3rd party contributors to contribute. To achieve that, we need to gradually upstream our changes.
To upstream these changes, I doubt that the maintainers of CCI would like the Boost version bump though, since it isn't a necessary change.
A few years ago, they easily accepted version changes, given something else changed as well.
Not sure what the policy right now is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NuDB recipe will not build when using Boost 1.89+ as
boost::systemis no longer there, and has actually not even been needed since Boost 1.69. See also conan-io#28808.This change, therefore, removes that requirement from NuDB's
conanfile.py. Local testing withxrpldshows that the compilation succeeds.