chore: run VSCode autolint on all files#5657
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5657 +/- ##
=========================================
- Coverage 78.8% 78.8% -0.0%
=========================================
Files 814 814
Lines 71295 71294 -1
Branches 8346 8370 +24
=========================================
- Hits 56192 56162 -30
- Misses 15103 15132 +29 🚀 New features to boost your workflow:
|
|
Thanks! How do we ensure this auto-formatting of Markdown files is also checked by clang-format? I see you added Javascript, but I suspect that future "bad" changes to Markdown files will not be corrected. |
I can add a CI check for Could we set that up in a separate PR, to limit the amount of times I have to update this PR? |
|
Sure, sounds good. |
Now that XRPLF#5657 has been squashed and merged, we can add its commit hash to .git-blame-ignore-revs
Now that XRPLF#5657 has been squashed and merged, we can add its commit hash to .git-blame-ignore-revs
…actoring-1 * XRPLF/develop: fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699) refactor: Revamp CI workflows (#5661) refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477) Set version to 2.6.0-rc2 docs: Updates list of maintainers and reviewers (#5687) fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686) fix: Add -Wno-deprecated-declarations for Clang only (#5680) Update .git-blame-ignore-revs for #5657 (#5675) Fix BUILD.md instruction (#5676) Set version to 2.6.0-rc1 fix: Improve logging of the reason to refuse a peer connection (#5664) fix: Make test suite names match the directory name (#5597) chore: Run prettier on all files (#5657) chore: Set CONAN_REMOTE_URL also for forks (#5662) chore: Cleanup bin/ directory (#5660) perf: Optimize hash performance by avoiding allocating hash state object (#5469)
…to ximinez/lending-XLS-66 * XRPLF/ximinez/lending-refactoring-4: fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699) refactor: Revamp CI workflows (#5661) refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477) Set version to 2.6.0-rc2 docs: Updates list of maintainers and reviewers (#5687) fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686) fix: Add -Wno-deprecated-declarations for Clang only (#5680) Update .git-blame-ignore-revs for #5657 (#5675) Fix BUILD.md instruction (#5676) Set version to 2.6.0-rc1 fix: Improve logging of the reason to refuse a peer connection (#5664) fix: Make test suite names match the directory name (#5597) chore: Run prettier on all files (#5657) chore: Set CONAN_REMOTE_URL also for forks (#5662) chore: Cleanup bin/ directory (#5660) perf: Optimize hash performance by avoiding allocating hash state object (#5469)
High Level Overview of Change
VSCode uses
prettierto format-on-save its code. So I ranprettieron the codebase, and added the missing languages to.clang-format.I reviewed the changes and they all don't change any of the output and do seem to make things cleaner.
There is no change in functionality whatsoever. Most of the changes are to Markdown files anyways. It's basically all just spacing changes.
Context of Change
Every time I edit a Markdown or YAML file, the autoformat-on-save in my editor formats the whole file. This essentially does it beforehand instead.
Type of Change
.gitignore, formatting, dropping support for older tooling)