Skip to content

chore: run VSCode autolint on all files#5657

Merged
bthomee merged 1 commit intoXRPLF:developfrom
mvadari:autolint
Aug 11, 2025
Merged

chore: run VSCode autolint on all files#5657
bthomee merged 1 commit intoXRPLF:developfrom
mvadari:autolint

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Aug 7, 2025

High Level Overview of Change

VSCode uses prettier to format-on-save its code. So I ran prettier on the codebase, and added the missing languages to .clang-format.

I reviewed the changes and they all don't change any of the output and do seem to make things cleaner.

There is no change in functionality whatsoever. Most of the changes are to Markdown files anyways. It's basically all just spacing changes.

Context of Change

Every time I edit a Markdown or YAML file, the autoformat-on-save in my editor formats the whole file. This essentially does it beforehand instead.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

@mvadari mvadari requested a review from a team August 7, 2025 17:31
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Aug 7, 2025
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.8%. Comparing base (abf12db) to head (fa870a9).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5657     +/-   ##
=========================================
- Coverage     78.8%   78.8%   -0.0%     
=========================================
  Files          814     814             
  Lines        71295   71294      -1     
  Branches      8346    8370     +24     
=========================================
- Hits         56192   56162     -30     
- Misses       15103   15132     +29     

see 10 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bthomee
Copy link
Collaborator

bthomee commented Aug 8, 2025

Thanks! How do we ensure this auto-formatting of Markdown files is also checked by clang-format? I see you added Javascript, but I suspect that future "bad" changes to Markdown files will not be corrected.

@mvadari
Copy link
Collaborator Author

mvadari commented Aug 11, 2025

Thanks! How do we ensure this auto-formatting of Markdown files is also checked by clang-format? I see you added Javascript, but I suspect that future "bad" changes to Markdown files will not be corrected.

I can add a CI check for prettier (which is what I ran to generate this), but it's going to be JS-based tooling. clang-format doesn't seem to have any ability to do Markdown formatting, unfortunately, so I don't think I can do it entirely in clang-format.

Could we set that up in a separate PR, to limit the amount of times I have to update this PR?

@bthomee
Copy link
Collaborator

bthomee commented Aug 11, 2025

Sure, sounds good.

@bthomee bthomee enabled auto-merge (squash) August 11, 2025 16:07
@bthomee bthomee merged commit 97f0747 into XRPLF:develop Aug 11, 2025
26 checks passed
@mvadari mvadari mentioned this pull request Aug 11, 2025
9 tasks
@mvadari mvadari deleted the autolint branch August 11, 2025 16:47
intelliot added a commit to intelliot/rippled that referenced this pull request Aug 12, 2025
Now that XRPLF#5657 has been squashed and merged, we can add its commit hash to .git-blame-ignore-revs
intelliot added a commit to intelliot/rippled that referenced this pull request Aug 13, 2025
Now that XRPLF#5657 has been squashed and merged, we can add its commit hash to .git-blame-ignore-revs
bthomee pushed a commit that referenced this pull request Aug 13, 2025
Now that #5657 has been squashed and merged, we can add its commit hash to .git-blame-ignore-revs.
@mathbunnyru mathbunnyru mentioned this pull request Aug 14, 2025
9 tasks
ximinez added a commit that referenced this pull request Aug 18, 2025
…actoring-1

* XRPLF/develop:
  fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699)
  refactor: Revamp CI workflows (#5661)
  refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477)
  Set version to 2.6.0-rc2
  docs: Updates list of maintainers and reviewers (#5687)
  fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686)
  fix: Add -Wno-deprecated-declarations for Clang only (#5680)
  Update .git-blame-ignore-revs for #5657 (#5675)
  Fix BUILD.md instruction (#5676)
  Set version to 2.6.0-rc1
  fix: Improve logging of the reason to refuse a peer connection (#5664)
  fix: Make test suite names match the directory name (#5597)
  chore: Run prettier on all files (#5657)
  chore: Set CONAN_REMOTE_URL also for forks (#5662)
  chore: Cleanup bin/ directory (#5660)
  perf: Optimize hash performance by avoiding allocating hash state object (#5469)
ximinez added a commit that referenced this pull request Aug 18, 2025
…to ximinez/lending-XLS-66

* XRPLF/ximinez/lending-refactoring-4:
  fix: Modify jobs to use '>>' instead of 'tee' for GITHUB_OUTPUT (#5699)
  refactor: Revamp CI workflows (#5661)
  refactor: Decouple net from xrpld and move rpc-related classes to the rpc folder (#5477)
  Set version to 2.6.0-rc2
  docs: Updates list of maintainers and reviewers (#5687)
  fix: Change log to debug level for AMM offer retrieval and IOU payment check (#5686)
  fix: Add -Wno-deprecated-declarations for Clang only (#5680)
  Update .git-blame-ignore-revs for #5657 (#5675)
  Fix BUILD.md instruction (#5676)
  Set version to 2.6.0-rc1
  fix: Improve logging of the reason to refuse a peer connection (#5664)
  fix: Make test suite names match the directory name (#5597)
  chore: Run prettier on all files (#5657)
  chore: Set CONAN_REMOTE_URL also for forks (#5662)
  chore: Cleanup bin/ directory (#5660)
  perf: Optimize hash performance by avoiding allocating hash state object (#5469)
This was referenced Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants