Batch PR1: Add tfInnerBatchTxn to all transactions#653
Merged
Conversation
Signed-off-by: David Fuelling <sappenin@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
============================================
+ Coverage 92.53% 92.65% +0.11%
- Complexity 2103 2145 +42
============================================
Files 432 433 +1
Lines 5735 5840 +105
Branches 510 510
============================================
+ Hits 5307 5411 +104
Misses 280 280
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 3, 2026
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first-of-three PRs required to implement Batch transactions (XLS-56). This PR adds the
tfInnerBatchTxnto the baseTransactionclass, and ensures this flag works properly with all transaction classes that implementTransaction.Before merging this, the following need to merge first:
definitions.jsonwith new values #674After this PR, #654 and #676 can be merged.