Skip to content

Batch PR1: Add tfInnerBatchTxn to all transactions#653

Merged
sappenin merged 9 commits intomainfrom
df/batch/add-flags
Feb 10, 2026
Merged

Batch PR1: Add tfInnerBatchTxn to all transactions#653
sappenin merged 9 commits intomainfrom
df/batch/add-flags

Conversation

@sappenin
Copy link
Collaborator

@sappenin sappenin commented Jan 25, 2026

This is the first-of-three PRs required to implement Batch transactions (XLS-56). This PR adds the tfInnerBatchTxn to the base Transaction class, and ensures this flag works properly with all transaction classes that implement Transaction.

Before merging this, the following need to merge first:

After this PR, #654 and #676 can be merged.

Signed-off-by: David Fuelling <sappenin@gmail.com>
@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.65%. Comparing base (4c1b8e8) to head (74a3bb7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/org/xrpl/xrpl4j/model/flags/BatchFlags.java 97.22% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #653      +/-   ##
============================================
+ Coverage     92.53%   92.65%   +0.11%     
- Complexity     2103     2145      +42     
============================================
  Files           432      433       +1     
  Lines          5735     5840     +105     
  Branches        510      510              
============================================
+ Hits           5307     5411     +104     
  Misses          280      280              
- Partials        148      149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sappenin sappenin changed the title Add tfInnerBatchTxn to all transactions Batch PR#1: Add tfInnerBatchTxn to all transactions Jan 25, 2026
@sappenin sappenin changed the title Batch PR#1: Add tfInnerBatchTxn to all transactions Batch PR1: Add tfInnerBatchTxn to all transactions Jan 25, 2026
@sappenin sappenin requested a review from Patel-Raj11 January 25, 2026 23:11
@sappenin sappenin self-assigned this Jan 25, 2026
@sappenin sappenin marked this pull request as ready for review February 7, 2026 00:58
Signed-off-by: David Fuelling <sappenin@gmail.com>
Copy link
Collaborator

@Patel-Raj11 Patel-Raj11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@sappenin sappenin merged commit 5e3ca5f into main Feb 10, 2026
17 of 19 checks passed
@sappenin sappenin deleted the df/batch/add-flags branch February 10, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants