Batch PR2: Add initial Batch support by sappenin · Pull Request #654 · XRPLF/xrpl4j

sappenin · 2026-01-25T23:08:10Z

This is the second-of-three PRs required to implement Batch transactions (XLS-56).

This PR implements all of the primitives and signing operations required to support Batch transactions.

Before merging, the following PRs must be merged first:

After this PR, #676 can be merged.

Signed-off-by: David Fuelling <sappenin@gmail.com>

Outer batch signing is just like any other transaction; the binary codec handles the proper encoding. Signed-off-by: David Fuelling <sappenin@gmail.com>

Signed-off-by: David Fuelling <sappenin@gmail.com>

codecov · 2026-01-28T19:52:19Z

Codecov Report

❌ Patch coverage is 97.52066% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.95%. Comparing base (5e3ca5f) to head (05e8e68).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../org/xrpl/xrpl4j/codec/binary/XrplBinaryCodec.java	89.18%	2 Missing and 2 partials ⚠️
...java/org/xrpl/xrpl4j/model/transactions/Batch.java	99.17%	0 Missing and 1 partial ⚠️
...rg/xrpl/xrpl4j/model/transactions/BatchSigner.java	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #654      +/-   ##
============================================
+ Coverage     92.65%   92.95%   +0.29%     
- Complexity     2145     2245     +100     
============================================
  Files           433      437       +4     
  Lines          5840     6071     +231     
  Branches        510      538      +28     
============================================
+ Hits           5411     5643     +232     
+ Misses          280      279       -1     
  Partials        149      149

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…batch/add-flags

Signed-off-by: David Fuelling <sappenin@gmail.com>

…batch/initial-support Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/ObjectMapperFactory.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/ZonedDateTimeDeserializer.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/ZonedDateTimeSerializer.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/AbstractJsonTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/client/amm/AmmInfoResultTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/flags/AccountRootFlagsTests.java

Signed-off-by: David Fuelling <sappenin@gmail.com>

Validates that BatchSigners contains signatures from all accounts whose inner transactions are included, excluding the account signing the outer transaction. Signed-off-by: David Fuelling <sappenin@gmail.com>

Signed-off-by: David Fuelling <sappenin@gmail.com>

Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/main/resources/definitions.json # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/client/fees/FeeUtilsTest.java

Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/flags/AccountSetTransactionFlagsTests.java

Signed-off-by: David Fuelling <sappenin@gmail.com>

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/SignatureUtilsTest.java

* Fix typos * Remove commented-out code. Signed-off-by: David Fuelling <sappenin@gmail.com>

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Batch.java

Patel-Raj11

nit: Add checks for each inner transaction in Batch.

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin added 5 commits January 25, 2026 15:52

Update tfInnerBatchTxn to all transactions

daafce0

Signed-off-by: David Fuelling <sappenin@gmail.com>

Initial commit of Batch

7df6bcc

Signed-off-by: David Fuelling <sappenin@gmail.com>

More updates

81e00eb

Signed-off-by: David Fuelling <sappenin@gmail.com>

Remove IT

df4528a

Signed-off-by: David Fuelling <sappenin@gmail.com>

Add Batch IT

a1811c9

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin changed the title ~~Add initial Batch support~~ Batch PR#3: Add initial Batch support Jan 25, 2026

sappenin changed the title ~~Batch PR#3: Add initial Batch support~~ Batch PR#2: Add initial Batch support Jan 25, 2026

sappenin changed the title ~~Batch PR#2: Add initial Batch support~~ Batch PR2: Add initial Batch support Jan 25, 2026

sappenin self-assigned this Jan 25, 2026

sappenin requested a review from Patel-Raj11 January 25, 2026 23:12

sappenin added 6 commits January 27, 2026 17:24

Deprecate multiSignToSigner to align with Batch and non-Batch design

072a241

Signed-off-by: David Fuelling <sappenin@gmail.com>

Cherry-pick Jackson fixes

bff5f5f

Signed-off-by: David Fuelling <sappenin@gmail.com>

Fix Account exclusion logic + unit test

c44365b

Signed-off-by: David Fuelling <sappenin@gmail.com>

Simplify contract for signing Batch transactions

cefb207

Outer batch signing is just like any other transaction; the binary codec handles the proper encoding. Signed-off-by: David Fuelling <sappenin@gmail.com>

Fix Checkstyle

151d2aa

Signed-off-by: David Fuelling <sappenin@gmail.com>

Remove IT for other branch

b818155

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin added 2 commits February 2, 2026 18:09

Merge branch 'main' into df/batch/add-flags

fba6c20

Merge branch 'df/batch/add-flags' into df/batch/initial-support

896a2ab

This was referenced Feb 3, 2026

Batch PR1: Add tfInnerBatchTxn to all transactions #653

Merged

Batch PR3: Add ITs for Batch #676

Merged

sappenin added 9 commits February 4, 2026 15:58

Merge branch 'main' into df/batch/add-flags

b2a6637

Merge branch 'main' into df/batch/add-flags

1688d1d

Merge branch 'df/batch/add-flags' of github.com:XRPLF/xrpl4j into df/…

6f75231

…batch/add-flags

Increase coverage of BatchFlags

a009e77

Signed-off-by: David Fuelling <sappenin@gmail.com>

Improve unit test coverage

17b82d2

Signed-off-by: David Fuelling <sappenin@gmail.com>

Fix checkstyle

6e9a7d4

Signed-off-by: David Fuelling <sappenin@gmail.com>

Add additional precondition for Batch

02d93e5

Validates that BatchSigners contains signatures from all accounts whose inner transactions are included, excluding the account signing the outer transaction. Signed-off-by: David Fuelling <sappenin@gmail.com>

Cleanup TODO

a3872e9

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin added 3 commits February 6, 2026 17:39

Refactor txId computation to private helper

7bb33aa

Signed-off-by: David Fuelling <sappenin@gmail.com>

Merge branch 'main' into df/batch/add-flags

a087cb5

Merge branch 'df/batch/add-flags' into df/batch/initial-support

5d2ce0e

Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/main/resources/definitions.json # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/client/fees/FeeUtilsTest.java

sappenin marked this pull request as ready for review February 7, 2026 00:58

sappenin requested review from nhartner and nkramer44 as code owners February 7, 2026 00:58

sappenin removed request for nhartner and nkramer44 February 7, 2026 00:58

sappenin mentioned this pull request Feb 10, 2026

Consider pulling Batch InnerTransaction TX Hash generator into RawTransactionWrapper #692

Open

Base automatically changed from df/batch/add-flags to main February 10, 2026 20:19

sappenin added 3 commits February 10, 2026 13:21

Merge branch 'main' into df/batch/initial-support

aeb43d4

Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/flags/AccountSetTransactionFlagsTests.java

Fix formatting

472fdec

Signed-off-by: David Fuelling <sappenin@gmail.com>

Enforce inner transaction check

9ac8f66

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin commented Feb 10, 2026

View reviewed changes

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/SignatureUtilsTest.java Show resolved Hide resolved

xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/SignatureUtilsTest.java Show resolved Hide resolved

Misc cleanup

35a0a62

* Fix typos * Remove commented-out code. Signed-off-by: David Fuelling <sappenin@gmail.com>

Patel-Raj11 reviewed Feb 11, 2026

View reviewed changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Batch.java Show resolved Hide resolved

Patel-Raj11 requested changes Feb 11, 2026

View reviewed changes

sappenin added 5 commits February 18, 2026 17:28

Update Batch per PR review

72981b9

Signed-off-by: David Fuelling <sappenin@gmail.com>

Add precondition checks to Batch

1a06b44

Signed-off-by: David Fuelling <sappenin@gmail.com>

Update Javadoc

5a2bd74

Signed-off-by: David Fuelling <sappenin@gmail.com>

Add deterministic regression tests

60276e6

Signed-off-by: David Fuelling <sappenin@gmail.com>

Fix checkstyle

0815b12

Signed-off-by: David Fuelling <sappenin@gmail.com>

Patel-Raj11 previously approved these changes Feb 19, 2026

View reviewed changes

Increase CodeCov

b4107fb

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin dismissed Patel-Raj11’s stale review via b4107fb February 19, 2026 21:21

Fix checkstyle

05e8e68

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin merged commit 3fc147c into main Feb 19, 2026
17 of 19 checks passed

sappenin deleted the df/batch/initial-support branch February 19, 2026 22:31

sappenin mentioned this pull request Feb 20, 2026

Add support for Batch transactions (XLS-56d) #581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch PR2: Add initial Batch support#654

Batch PR2: Add initial Batch support#654
sappenin merged 36 commits intomainfrom
df/batch/initial-support

sappenin commented Jan 25, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Patel-Raj11 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sappenin commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Patel-Raj11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sappenin commented Jan 25, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited

Loading