Batch PR3: Add ITs for Batch by sappenin · Pull Request #676 · XRPLF/xrpl4j

sappenin · 2026-01-28T19:34:56Z

This is the third-of-three PRs required to implement Batch transactions (XLS-56).

This PR adds an integration test that fully covers Batch transactions with a real xrpld node.

Before merging, the following PRs must be merged first:

Signed-off-by: David Fuelling <sappenin@gmail.com>

Outer batch signing is just like any other transaction; the binary codec handles the proper encoding. Signed-off-by: David Fuelling <sappenin@gmail.com>

Signed-off-by: David Fuelling <sappenin@gmail.com>

codecov · 2026-01-28T19:41:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (3fc147c) to head (89e3412).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #676      +/-   ##
============================================
- Coverage     92.95%   92.91%   -0.04%     
+ Complexity     2245     2220      -25     
============================================
  Files           437      437              
  Lines          6071     6025      -46     
  Branches        538      536       -2     
============================================
- Hits           5643     5598      -45     
  Misses          279      279              
+ Partials        149      148       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…batch/add-flags

Signed-off-by: David Fuelling <sappenin@gmail.com>

…batch/initial-support Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/ObjectMapperFactory.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/ZonedDateTimeDeserializer.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/ZonedDateTimeSerializer.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/AbstractJsonTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/client/amm/AmmInfoResultTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/flags/AccountRootFlagsTests.java

Signed-off-by: David Fuelling <sappenin@gmail.com>

Validates that BatchSigners contains signatures from all accounts whose inner transactions are included, excluding the account signing the outer transaction. Signed-off-by: David Fuelling <sappenin@gmail.com>

Signed-off-by: David Fuelling <sappenin@gmail.com>

…to df/batch/add-its

Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/main/resources/definitions.json # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/client/fees/FeeUtilsTest.java

Patel-Raj11

LGTM!

The base branch was changed.

Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/codec/binary/XrplBinaryCodec.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/crypto/signing/TransactionSigner.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Batch.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/RawTransactionWrapper.java # xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Signer.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/codec/binary/XrplBinaryCodecTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/AbstractTransactionSignerTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/crypto/signing/SignatureUtilsTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/client/fees/FeeUtilsTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/flags/AccountSetTransactionFlagsTests.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/BatchSignerTest.java # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/transactions/BatchTest.java

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Transaction.java

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin added 12 commits January 25, 2026 15:52

Update tfInnerBatchTxn to all transactions

daafce0

Signed-off-by: David Fuelling <sappenin@gmail.com>

Initial commit of Batch

7df6bcc

Signed-off-by: David Fuelling <sappenin@gmail.com>

More updates

81e00eb

Signed-off-by: David Fuelling <sappenin@gmail.com>

Remove IT

df4528a

Signed-off-by: David Fuelling <sappenin@gmail.com>

Add Batch IT

a1811c9

Signed-off-by: David Fuelling <sappenin@gmail.com>

Deprecate multiSignToSigner to align with Batch and non-Batch design

072a241

Signed-off-by: David Fuelling <sappenin@gmail.com>

Cherry-pick Jackson fixes

bff5f5f

Signed-off-by: David Fuelling <sappenin@gmail.com>

Fix Account exclusion logic + unit test

c44365b

Signed-off-by: David Fuelling <sappenin@gmail.com>

Simplify contract for signing Batch transactions

cefb207

Outer batch signing is just like any other transaction; the binary codec handles the proper encoding. Signed-off-by: David Fuelling <sappenin@gmail.com>

Fix Checkstyle

151d2aa

Signed-off-by: David Fuelling <sappenin@gmail.com>

Remove IT for other branch

b818155

Signed-off-by: David Fuelling <sappenin@gmail.com>

Add IT

01ac213

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin self-assigned this Jan 28, 2026

sappenin mentioned this pull request Jan 28, 2026

Batch PR3: Add ITs for Batch #655

Merged

sappenin added 3 commits February 2, 2026 18:09

Merge branch 'main' into df/batch/add-flags

fba6c20

Merge branch 'df/batch/add-flags' into df/batch/initial-support

896a2ab

Merge branch 'df/batch/initial-support' into df/batch/add-its

a135bc1

sappenin mentioned this pull request Feb 3, 2026

Batch PR1: Add tfInnerBatchTxn to all transactions #653

Merged

sappenin added 11 commits February 4, 2026 15:58

Merge branch 'main' into df/batch/add-flags

b2a6637

Merge branch 'main' into df/batch/add-flags

1688d1d

Merge branch 'df/batch/add-flags' of github.com:XRPLF/xrpl4j into df/…

6f75231

…batch/add-flags

Increase coverage of BatchFlags

a009e77

Signed-off-by: David Fuelling <sappenin@gmail.com>

Improve unit test coverage

17b82d2

Signed-off-by: David Fuelling <sappenin@gmail.com>

Fix checkstyle

6e9a7d4

Signed-off-by: David Fuelling <sappenin@gmail.com>

Merge branch 'df/batch/initial-support' into df/batch/add-its

a06fd62

Add additional precondition for Batch

02d93e5

Validates that BatchSigners contains signatures from all accounts whose inner transactions are included, excluding the account signing the outer transaction. Signed-off-by: David Fuelling <sappenin@gmail.com>

Cleanup TODO

a3872e9

Signed-off-by: David Fuelling <sappenin@gmail.com>

Refactor txId computation to private helper

7bb33aa

Signed-off-by: David Fuelling <sappenin@gmail.com>

sappenin added 4 commits February 6, 2026 17:41

Merge branch 'df/batch/initial-support' of github.com:XRPLF/xrpl4j in…

c36bd67

…to df/batch/add-its

Merge branch 'main' into df/batch/add-flags

a087cb5

Merge branch 'df/batch/add-flags' into df/batch/initial-support

5d2ce0e

Signed-off-by: David Fuelling <sappenin@gmail.com> # Conflicts: # xrpl4j-core/src/main/resources/definitions.json # xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/client/fees/FeeUtilsTest.java

Merge branch 'df/batch/initial-support' into df/batch/add-its

848d2a2

sappenin mentioned this pull request Feb 7, 2026

Batch PR2: Add initial Batch support #654

Merged

sappenin marked this pull request as ready for review February 7, 2026 01:00

sappenin requested review from nhartner and nkramer44 as code owners February 7, 2026 01:00

sappenin requested review from Patel-Raj11 and removed request for nhartner and nkramer44 February 7, 2026 01:00

Patel-Raj11 previously approved these changes Feb 11, 2026

View reviewed changes

Base automatically changed from df/batch/initial-support to main February 19, 2026 22:31

sappenin requested a review from Patel-Raj11 February 20, 2026 00:33

sappenin commented Feb 20, 2026

View reviewed changes

xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/transactions/Transaction.java Outdated Show resolved Hide resolved

sappenin added 2 commits February 19, 2026 17:36

Remove code comment.

5c17b79

Signed-off-by: David Fuelling <sappenin@gmail.com>

Remove unused import

89e3412

Signed-off-by: David Fuelling <sappenin@gmail.com>

Patel-Raj11 approved these changes Feb 20, 2026

View reviewed changes

sappenin merged commit 3bda0db into main Feb 20, 2026
17 of 19 checks passed

sappenin deleted the df/batch/add-its branch February 20, 2026 15:58

sappenin mentioned this pull request Feb 20, 2026

Add support for Batch transactions (XLS-56d) #581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch PR3: Add ITs for Batch#676

Batch PR3: Add ITs for Batch#676
sappenin merged 33 commits intomainfrom
df/batch/add-its

sappenin commented Jan 28, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 28, 2026 •

edited

Loading

Uh oh!

Patel-Raj11 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sappenin commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Patel-Raj11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sappenin commented Jan 28, 2026 •

edited

Loading

codecov bot commented Jan 28, 2026 •

edited

Loading