[AIE2P][AIE2] Split symmetric G_BUILD_VECTOR into two G_BUILD_VECTORs #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinay-anubola
requested review from
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
from
51b9ad9 to
6d0d5be
Compare
khallouh
reviewed
Mar 24, 2025
khallouh
reviewed
Mar 24, 2025
khallouh
reviewed
Mar 24, 2025
khallouh
reviewed
Mar 24, 2025
khallouh
reviewed
Mar 24, 2025
llvm/test/CodeGen/AIE/GlobalISel/prelegalizercombiner-symmetric-build-vector.mir
Show resolved
Hide resolved
niwinanto
reviewed
Mar 24, 2025
niwinanto
reviewed
Mar 24, 2025
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
from
6d0d5be to
36549ac
Compare
khallouh
reviewed
Mar 26, 2025
|
Working on more generic way to adding more patterns like quarters and single diff splat on parts. |
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
from
36549ac to
1bcbfcd
Compare
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
from
1bcbfcd to
909b0e5
Compare
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
2 times, most recently
from
2fcf78c to
7b5cdbd
Compare
andcarminati
reviewed
Apr 8, 2025
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
from
7b5cdbd to
9e257cd
Compare
|
Hi @abhinay-anubola, do you have some QoR numbers to share? |
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
from
9e257cd to
6d81ed5
Compare
…ne_symmetric_build_vector
abhinay-anubola
force-pushed
the
sanubola.symmetric.build.vector
branch
from
6d81ed5 to
b280581
Compare
martien-de-jong
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the symmetric G_BUILD_VECTOR into two half-sized G_BUILD_VECTOR operations and then emits a G_CONCAT_VECTORS to combine them back into the final vector.