[Draft][wip]Mimic vector composition hierarchy for accumulators. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niwinanto
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
niwinanto
changed the title
khallouh
reviewed
Apr 9, 2025
| def mCMs : AIE2PAcc1024RegisterClass<(add mCMm)>; | ||
| } // let SubRegIndices = [sub_512_lo, sub_512_hi], CoveredBySubRegs = 1 | ||
|
|
||
| def eCML : AIE2PVector1024RegisterClass<(add cml0, cml1, cml2, cml3, cml4)>; |
There was a problem hiding this comment.
Curious, was this change also needed or just the dummy registers were enough?
niwinanto
force-pushed
the
niwin.lanemask.regbank
branch
from
0fb8751 to
0575190
Compare
|
Maybe a description of the idea would be nice to help us to help. |
| @@ -33,8 +33,8 @@ def sub_512_hi : SubRegIndex<512, 512>; | |||
| def sub_512_acc_lo : SubRegIndex<512, 0>; | |||
| def sub_512_acc_hi : SubRegIndex<512, 512>; | |||
|
|
|||
| def sub_1024_acc_lo : SubRegIndex<1024, 0>; | |||
| def sub_1024_acc_hi : SubRegIndex<1024, 1024>; | |||
| def sub_1024_lo : SubRegIndex<1024, 0>; | |||
There was a problem hiding this comment.
I think this will lead to another problem. I heard once that we cannot reuse this for different register classes, maybe is related to the same problem that we have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.