[AIEX] Make the decision to accept supplied II stronger #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andcarminati
requested review from
F-Stuckmann,
SagarMaheshwari99,
abhinay-anubola,
abnikant,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto and
stephenneuendorffer
as code owners
|
|
||
| // PostPipeliner can do nothing without tripcount > 1 | ||
| if (MinTripCount <= 1) { | ||
| if (MinTripCount <= 1 || HasIIPragma) { |
Collaborator
There was a problem hiding this comment.
so specifying an II now is equivalent to disable prepipeliner?
Collaborator
Author
There was a problem hiding this comment.
Is the other way around: if we specify an II we don't prefer the postpipeliner. I changed because we were still preferring the postpipeliner for a user specified II when SDep.getSignedLatency() >= II (see last condition).
Collaborator
There was a problem hiding this comment.
Sorry, I thought this was the canAccept() method.
martien-de-jong
approved these changes
Apr 30, 2025
mgehre-amd
added a commit
that referenced
this pull request
Aug 21, 2025
Fix for upstream change in docker container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.