Skip to content

[AIEX] Make the decision to accept supplied II stronger #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andcarminati merged 1 commit into from
Apr 30, 2025
Merged

[AIEX] Make the decision to accept supplied II stronger #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Target/AIE/AIEBasePipelinerLoopInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,13 +756,13 @@ bool ZeroOverheadLoop::preferPostPipeliner(SMSchedule &SMS) {
// job on multi-stage live-ranges without spilling or moving.

// PostPipeliner can do nothing without tripcount > 1
if (MinTripCount <= 1) {
if (MinTripCount <= 1 || HasIIPragma) {
Copy link
Collaborator

@martien-de-jong martien-de-jong Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so specifying an II now is equivalent to disable prepipeliner?

Copy link
Collaborator Author

@andcarminati andcarminati Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the other way around: if we specify an II we don't prefer the postpipeliner. I changed because we were still preferring the postpipeliner for a user specified II when SDep.getSignedLatency() >= II (see last condition).

Copy link
Collaborator

@martien-de-jong martien-de-jong Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought this was the canAccept() method.

return false;
}

unsigned NS = SMS.getMaxStageCount() + 1;
int II = SMS.getInitiationInterval();
if (!HasIIPragma && NS > LoopMaxStageCount && II < PostPipelinerCutoff) {
if (NS > LoopMaxStageCount && II < PostPipelinerCutoff) {
LLVM_DEBUG(dbgs() << "PLI: Leaving high stage count for PostPipeliner\n");
return true;
}
Expand Down