Repoint mlirDistro.yml at ROCm/llvm-project#3324
Open
jgmelber wants to merge 2 commits into
Open
Conversation
Repoints the canonical mlirDistro.yml pipeline at ROCm/llvm-project (default branch amd-staging) instead of upstream llvm/llvm-project, pinned at the commit already validated end-to-end in #3314 (mlir-aie builds and runs real AIE compilations against it). It keeps publishing to the same mlir-distro release tag, so every downstream consumer (mlirAIEDistro.yml, buildAndTestPythons.yml, buildAndTestRyzenAI.yml, and the rest) picks this up transparently with no changes of their own. mlirDistroRocm.yml is retired: mlirDistro.yml now builds from ROCm directly, so the standalone ROCm-only pipeline is redundant. update-llvm.yml's biweekly schedule is paused (workflow_dispatch kept) since utils/update_llvm_version.py is hardcoded to upstream llvm/llvm-project and would otherwise silently propose reverting this migration. Do not merge until #3323 (validate the ROCm wheel on Ryzen AI self-hosted runners) has run and passed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jgmelber
requested review from
abisca,
andrej,
erwei-xilinx,
fifield,
hunhoffe,
jackl-xilinx and
stephenneuendorffer
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the canonical MLIR distro wheel build to source LLVM/MLIR from ROCm/llvm-project (amd-staging) instead of upstream llvm/llvm-project, while keeping downstream consumers pinned to the existing mlir-distro release tag.
Changes:
- Repointed LLVM source acquisition to
ROCm/llvm-projectin the distro workflow and clone helper script, and bumped the pinned LLVM commit. - Disabled the scheduled
update-llvm.ymlautomation to avoid it auto-opening PRs that would revert the ROCm migration. - Removed the now-redundant
mlirDistroRocm.ymlworkflow.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| utils/clone-llvm.sh | Updates pinned LLVM commit and clone URL to ROCm/llvm-project. |
| .github/workflows/mlirDistro.yml | Switches “latest commit” lookup + codeload download to ROCm fork/branch while keeping mlir-distro publishing. |
| .github/workflows/update-llvm.yml | Pauses scheduled runs to prevent upstream-oriented auto-update PRs. |
| .github/workflows/mlirDistroRocm.yml | Deletes the ROCm-only workflow now that the canonical workflow uses ROCm directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
105
to
+108
| RESPONSE=$(curl --fail-with-body -sSL \ | ||
| -H "Authorization: Bearer $GH_TOKEN" \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| https://api.github.com/repos/llvm/llvm-project/commits/main) || { | ||
| https://api.github.com/repos/ROCm/llvm-project/commits/amd-staging) || { |
Splitting the migration into two stages per review: this PR only repoints mlirDistro.yml at ROCm/llvm-project so it starts publishing ROCm-built wheels under the existing mlir-distro tag. It's safe to land on its own since utils/clone-llvm.sh is untouched, so no consumer's pinned wheel version changes yet. utils/clone-llvm.sh's version bump, retiring mlirDistroRocm.yml, and pausing update-llvm.yml's schedule move to a follow-up PR, landed only once mlirDistro.yml has actually published a matching wheel under mlir-distro (otherwise every consumer 404s trying to pip install a version that was only ever published under rocm-mlir-distro — which is exactly what happened when this was all one PR). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jgmelber
changed the title
3 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repoints the canonical
mlirDistro.ymlpipeline from upstreamllvm/llvm-projecttoROCm/llvm-project, having validated the switch end-to-end in #3314 (closed — build + smoke test passed againstrocm-mlir-distrowheels, and I separately confirmed a real programming example compiles through the full pipeline against this build)..github/workflows/mlirDistro.yml: repointed its two upstream references (the scheduled "latest commit" lookup, and the "Get LLVM" codeload URL) atROCm/llvm-project'samd-stagingbranch. Everything else — the0 */4 * * *schedule, PR trigger, and themlir-distro/dev-wheelsrelease tags it publishes to — is unchanged.Scoped down from the original version of this PR (which also bumped
utils/clone-llvm.sh's pin, retiredmlirDistroRocm.yml, and pausedupdate-llvm.yml) after that combined version broke ~all downstream CI: bumpingclone-llvm.shto a version only published underrocm-mlir-distroimmediately 404s every consumer that still readsmlir-distro, sincemlirDistro.ymlhadn't actually run against the new source yet to publish a matching wheel there. This PR alone is safe to land —clone-llvm.shis untouched, so no consumer's pinned wheel version changes until the follow-up PR.Copilot review carried forward: checked the original PR that added
mlirDistroRocm.yml(#3311) for outstanding Copilot suggestions, since this replaces that workflow's role. It flagged (1) aDocker prunestep referencing a nonexistentinputs.MATRIX_OS, (2) shell-quoting/glob issues in a "Get wheel version" step, and (3) a hardcodedllvm-project-*glob despite an overridableLLVM_REPOinput — all three were already fixed before #3311 merged, and none apply to this diff anyway since it reusesmlirDistro.yml's original, unaffected code paths rather thanmlirDistroRocm.yml's adapted copy.Follow-up (separate PR, not yet opened)
Once this merges, dispatch
mlirDistro.ymlwithLLVM_COMMIT=46fcb339fb61119b337f973c7ca9e710a319fdd0explicitly set (not auto-latest) so it publishes the exact validated wheel undermlir-distro. Only then open the follow-up PR bumpingutils/clone-llvm.shto that same commit/datetime, retiringmlirDistroRocm.yml, and pausingupdate-llvm.yml— gated on #3323 (Ryzen AI hardware validation) passing first.Test plan
mlirDistro.ymlon this branch and confirm it builds successfully againstROCm/llvm-projectdev-wheels/mlir-distrotag as expected for a PR-triggered run🤖 Generated with Claude Code