feat: rcl unit test - #36
Merged
Merged
Conversation
YuanYuYuan
force-pushed
the
feat/rcl-unit-test
branch
from
November 24, 2025 13:40
a55c45c to
a0129cd
Compare
YuanYuYuan
marked this pull request as draft
November 24, 2025 13:41
- test_client.rs - test_publisher.rs - test_init.rs - test_context.rs - test_node.rs - test_service.rs - test_common.rs - test_domain_id.rs - test_expand_topic_name.rs - test_get_actual_qos.rs - test_time.rs
local discovery in graph
YuanYuYuan
force-pushed
the
feat/rcl-unit-test
branch
from
November 29, 2025 09:37
9060835 to
24ba70a
Compare
YuanYuYuan
marked this pull request as ready for review
November 29, 2025 09:55
YuanYuYuan
added a commit
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements comprehensive unit test coverage for the rcl-z ROS 2 client library,
ported from the upstream ROS 2 rcl test suite.
The implementation includes critical bug fixes, feature additions, and improvements to align with ROS 2 behavior.
Closes #20.
Summary:
Changes
New Features
Arguments System (src/arguments.rs)
--ros-args,--param,--remap, etc.)--params-file)Event System (src/event.rs)
Topic Name Validation (src/validate_topic_name.rs)
Test Coverage
Core functionality tests:
Communication tests:
Time and synchronization tests:
Graph and discovery tests:
QoS and configuration tests:
Utility tests:
Bug Fixes
Initialization Issues
..Default::default()usage)Service Implementation
Publisher/Subscription
ROS_DISABLE_LOANED_MESSAGESenvironment variable handlingTimer System
Infrastructure Improvements
Build System (flake.nix, Cargo.toml)
test-core,test-msgs,test-allclippywith--all-targets --all-featuresType Support (build.rs)
test_msgsavailability viahas_test_msgscfgCode Organization