Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ready for data tagging #9833

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

This adds ansible/ansible#84621 to CI to test whether it causes problems in CI.

Ref: https://forum.ansible.com/t/data-tagging-preview-and-testing/40759
Ref: https://forum.ansible.com/t/data-tagging-playground/39909

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

CI

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added WIP Work in progress tests tests unit tests/unit labels Mar 5, 2025
@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test pylint [explain] failed with 1 error:

plugins/callback/yaml.py:56:0: inherit-non-class: Inheriting 'AnsibleDumper', which is not a class.

The test ansible-test sanity --test import --python 3.11 [explain] failed with 1 error:

plugins/callback/yaml.py:56:0: traceback: TypeError: function() argument 'code' must be code, not str

The test ansible-test sanity --test import --python 3.12 [explain] failed with 1 error:

plugins/callback/yaml.py:56:0: traceback: TypeError: function() argument 'code' must be code, not str

The test ansible-test sanity --test import --python 3.13 [explain] failed with 1 error:

plugins/callback/yaml.py:56:0: traceback: TypeError: function() argument 'code' must be code, not str

click here for bot help

@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 6, 2025
@felixfontein

This comment was marked as outdated.

@felixfontein

This comment was marked as outdated.

@felixfontein felixfontein added backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Mar 8, 2025
@ansibullbot ansibullbot added integration tests/integration lookup lookup plugin plugins plugin (any type) labels Mar 8, 2025
@felixfontein felixfontein force-pushed the ci-data-tagging branch 3 times, most recently from 017513e to 9d501ca Compare March 8, 2025 14:01
@felixfontein felixfontein changed the title [DO NOT MERGE] Add data tagging PR to CI [WIP] Add data tagging PR to CI Mar 8, 2025
@felixfontein felixfontein changed the title [WIP] Add data tagging PR to CI [WIP] Make ready for data tagging Mar 8, 2025
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 9, 2025
@felixfontein felixfontein mentioned this pull request Mar 9, 2025
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added callback callback plugin filter filter plugin and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Mar 9, 2025
@felixfontein felixfontein changed the title [WIP] Make ready for data tagging Make ready for data tagging Mar 9, 2025
@felixfontein
Copy link
Collaborator Author

felixfontein commented Mar 9, 2025

Right now we have three bugfixes:

  • dependent look plugin (changes on how templating works);
  • reveal_ansible_type filter plugin and ansible_type test plugin (documentation needs updates, and the type names _AnsibleLazyTemplateDict and _AnsibleLazyTemplateList need special handling in the plugin utils code);
  • diy callback plugin (CallbackDIYDict cannot be used; omit is no longer a variable).

Further I had to disable three plugins due to bugs:

Whether the plugins/modules need changes or ansible-core needs fixes depends on the issue, we'll see what happens over time. The YAML callback issue also prevents the sanity tests from passing, since it's currently not possible to even import the YAML callback.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch callback callback plugin filter filter plugin integration tests/integration lookup lookup plugin plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests unit tests/unit WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants