Update surefire to 3.5.4 ; upgrade NestedDataScanQueryTest to use junit5 #18847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
kgyrtkirk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes of #18722 have triggered a bug in surefire which in turn started to write invalid report files.
It also passed thru the CI as surefire was failing incorrectly - but as a sideeffet it started causing interesting annotations which I've noticed today.
The test should have failed in that PR - however it hit this bug and hidden the problem...
With surefire 4.5.2 the issue happens "less" ; but it still fails to execute the
NestedDataScanQueryTest...most likely theJUnitParamsRunnerdoesn't work well with recent surefire and/or junit5...This PR upgraded surefire to 4.5.2 and disables the problematic testcases of
NestedDataScanQueryTest.