feat: add placeholderValue to page source tree #1016
+44
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
May 16, 2025
Moved the logic for constructing attribute blocks into a separate method for clarity and future extensibility. Also replaced direct type checks with a reusable fb_supportsPlaceholder helper on FBXCElementSnapshotWrapper.
… comment - Replaced custom placeholder support check with FBDoesElementSupportInnerText, as introduced in upstream PR - Updated comment for fb_attributeBlockMapForSnapshot to clarify usage context and avoid confusion about method placement
ikharebashviliGD
force-pushed
the
feat/add_placeholderValue_to_page_source
branch
from
3281454 to
7e9dbb4
Compare
| @@ -248,6 +238,43 @@ + (NSDictionary *)dictionaryForElement:(id<FBXCElementSnapshot>)snapshot | |||
| return info; | |||
| } | |||
|
|
|||
| // Helper used by `dictionaryForElement:` to assemble attribute value blocks, | |||
| // including both common attributes and conditionally included ones like placeholderValue. | |||
| + (NSDictionary<NSString *, NSString *(^)(void)> *)fb_attributeBlockMapForSnapshot:(id<FBXCElementSnapshot>)snapshot | |||
There was a problem hiding this comment.
we do not use the snapshot instance in this method. Also wrappedSnapshot anyway contains it
There was a problem hiding this comment.
@mykola-mokhnach Totally agree, removed the unused snapshot parameter and renamed the method. Also noticed some tests are failing — should I do something on my side or can someone help with that?
…pedSnapshot method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the placeholderValue attribute to be included in the response from the
/source(getPageSource) endpoint.Motivation
Previously,
placeholderValuewas only available when requesting attributes for a specific element. However, this attribute is also valuable when analyzing the full accessibility tree returned by/source, particularly for identifying input fields and verifying placeholder text during automated accessibility testing.By including
placeholderValuein the full snapshot, we enable better support for end-to-end validations and tools that rely on the complete accessibility hierarchy.