CodeOwnership integration #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipskis
added a commit
to lipskis/diagnose_tests
that referenced
this pull request
Aug 26, 2025
Add expectations for the `instrument_code_ownership` config option. Related to appsignal/appsignal-ruby#1443
lipskis
force-pushed
the
code-ownership-integration
branch
from
f84b1b0 to
06050bb
Compare
tombruijn
reviewed
Aug 26, 2025
tombruijn
reviewed
Aug 26, 2025
tombruijn
reviewed
Aug 26, 2025
unflxw
approved these changes
Aug 26, 2025
Add instrumentation to the `code_ownership` gem using the `before_complete` transaction hook. This change: - adds `instrument_code_ownership` configuration option that toggles instrumentation for the `code_ownership` gem - tags the current transaction with the owner of the module/class in which the error occurs - adds integration tests for annotation, directory and glob-based declaration methods - adds tests for hook setup
Add missing "ostruct" gem which is no longer available in the Ruby's standard library.
This change properly handles falsy values from `CodeOwnership.for_backtrace`. The change adds tests for internal error logging when config isn't set up correctly, swaps `require` for `load` and simplifies the integration spec.
lipskis
force-pushed
the
code-ownership-integration
branch
from
6b87833 to
761fe78
Compare
|
✔️ All good! |
tombruijn
approved these changes
Sep 18, 2025
lipskis
force-pushed
the
code-ownership-integration
branch
3 times, most recently
from
3f6f915 to
8200a33
Compare
tombruijn
approved these changes
Sep 18, 2025
unflxw
approved these changes
Sep 18, 2025
lipskis
force-pushed
the
code-ownership-integration
branch
from
8200a33 to
098f21b
Compare
unflxw
reviewed
Sep 19, 2025
Previously this branch was using a forked version of the `diagnose_tests` submodule and a specific branch. This change also adds a changeset.
lipskis
force-pushed
the
code-ownership-integration
branch
from
e48b7f0 to
40860cb
Compare
lipskis
pushed a commit
that referenced
this pull request
Oct 1, 2025
AppSignal currently produces log lines if no Team is found, which look like errors and can be confusing. ``` INFO -- : ║ [2025-09-30T18:13:32 (process) #8][ERROR] appsignal: Error while looking up CodeOwnership team: NoMethodError: undefined method `name' for nil ``` This change handles cases when no `Team` can be found for a `backtrace`. Follow-up to #1443
lipskis
pushed a commit
that referenced
this pull request
Oct 1, 2025
AppSignal currently produces log lines if no Team is found, which look like errors and can be confusing. This change handles cases when no `Team` can be found for a `backtrace`. Follow-up to #1443
fatkodima
added a commit
to fatkodima/appsignal-ruby
that referenced
this pull request
Oct 1, 2025
AppSignal currently produces log lines if transaction has no errors, which look like errors and can be confusing. This change handles cases when `error` is `nil`. Follow-up to appsignal#1443
lipskis
pushed a commit
that referenced
this pull request
Oct 2, 2025
AppSignal currently produces log lines if a transaction has no errors, which look like errors and can be confusing. This change handles cases when `error` is `nil`. Follow-up to #1443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds integration for the code_ownership gem.
Heavily inspired by #1364, this integration uses the
before_completetransaction hook and theCodeOwnership.for_backtracemethod to add instrumentation to thecode_ownershipgem.The PR:
instrument_code_ownershipconfiguration option that can toggle instrumentation for thecode_ownershipgemA minimal Rails test app that shows the integration in action can be found here.