Resolve remaining checkpatch.pl warnings in agnocast_kmod/. The checkpatch CI was introduced in #1251 and EMBEDDED_FUNCTION_NAME was fixed in #1252. The following logic-related warnings still remain:
Remaining warnings
Once all warnings are resolved, the checkpatch workflow should be made required
Reference: https://docs.kernel.org/dev-tools/checkpatch.html
Resolve remaining checkpatch.pl warnings in
agnocast_kmod/. The checkpatch CI was introduced in #1251 andEMBEDDED_FUNCTION_NAMEwas fixed in #1252. The following logic-related warnings still remain:Remaining warnings
SPDX_LICENSE_TAG(9): Missing SPDX license identifierOOM_MESSAGE(7): Unnecessary OOM messages (kernel already logs them)NEEDLESS_IF(3):if (p) kfree(p)—kfree(NULL)is safeMEMORY_BARRIER(3): Memory barriers without explanatory commentsCONSTANT_COMPARISON(3): Yoda-style comparisons (0 == x→x == 0)ALLOC_WITH_MULTIPLY(2): Usekvcallocinstead ofkvzallocwith multiplyGLOBAL_INITIALISERS(2): Remove redundant= 0/= falsefor globalsCONST_STRUCT(1):struct file_operationsshould beconstOnce all warnings are resolved, the checkpatch workflow should be made required
Reference: https://docs.kernel.org/dev-tools/checkpatch.html