Skip to content

docs(demos): add crosswalk passing guide in planning sim demo#514

Merged
xmfcx merged 4 commits intoautowarefoundation:mainfrom
Ericpotato:add-crosswalk-stop-tutorial
Dec 5, 2025
Merged

docs(demos): add crosswalk passing guide in planning sim demo#514
xmfcx merged 4 commits intoautowarefoundation:mainfrom
Ericpotato:add-crosswalk-stop-tutorial

Conversation

@Ericpotato
Copy link
Copy Markdown
Contributor

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Ericpotato Ericpotato force-pushed the add-crosswalk-stop-tutorial branch from bb4dcfe to 71b4da5 Compare January 30, 2024 06:24
@Ericpotato
Copy link
Copy Markdown
Contributor Author

@shmpwk It seems that I don't have the accessibility to assign a label or a reviewer. Can you help me ?

@Ericpotato Ericpotato marked this pull request as ready for review January 30, 2024 07:09
@shmpwk shmpwk requested review from KhalilSelyan and shmpwk January 30, 2024 07:10
@shmpwk shmpwk added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 30, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2024

@shmpwk
Copy link
Copy Markdown
Contributor

shmpwk commented Jan 30, 2024

Great work! I will leave minor comment.

Comment thread docs/tutorials/ad-hoc-simulation/planning-simulation.md Outdated
Comment thread docs/tutorials/ad-hoc-simulation/planning-simulation.md Outdated
Comment thread docs/tutorials/ad-hoc-simulation/planning-simulation.md Outdated
Comment thread docs/tutorials/ad-hoc-simulation/planning-simulation.md Outdated
@shmpwk
Copy link
Copy Markdown
Contributor

shmpwk commented Jan 31, 2024

@Ericpotato
Please check spell check CI.

Comment thread docs/tutorials/ad-hoc-simulation/planning-simulation.md Outdated
@Ericpotato Ericpotato force-pushed the add-crosswalk-stop-tutorial branch from ca37f32 to 7c8ec8e Compare February 1, 2024 10:05
@shmpwk
Copy link
Copy Markdown
Contributor

shmpwk commented Feb 5, 2024

As for signalized crosswalk, when the traffic light for the car is green and there is a pedestrian on the crosswalk which intersects with the planned route, the ego will drive without slowing down because of the crosswalk traffic light estimator.
Could you check the ego behavior again for the signalized crosswalk?

image

@shmpwk
Copy link
Copy Markdown
Contributor

shmpwk commented Feb 7, 2024

@Ericpotato
Could you modify the pull request title?

@Ericpotato Ericpotato changed the title docs(tutorials): add pull-over and pull-out scenario in tutorials page docs(tutorials): add crosswalk passing scenario in tutorials page Feb 7, 2024
@shmpwk shmpwk marked this pull request as draft March 29, 2024 10:45
@stale stale Bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 28, 2024
@shmpwk shmpwk marked this pull request as ready for review July 9, 2025 07:36
@stale stale Bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jul 9, 2025
@stale stale Bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 7, 2025
@Ericpotato Ericpotato closed this Oct 20, 2025
@shmpwk
Copy link
Copy Markdown
Contributor

shmpwk commented Oct 20, 2025

I'd like to reuse this PR for the future.

@shmpwk shmpwk reopened this Oct 20, 2025
@stale stale Bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Oct 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 20, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx changed the title docs(tutorials): add crosswalk passing scenario in tutorials page docs(demos): add crosswalk passing guide in planning sim demo Dec 2, 2025
@xmfcx xmfcx force-pushed the add-crosswalk-stop-tutorial branch from 7c8ec8e to e8b63cb Compare December 2, 2025 22:13
@xmfcx xmfcx force-pushed the add-crosswalk-stop-tutorial branch from b6f96b5 to 1f1bdb5 Compare December 2, 2025 22:20
@autowarefoundation autowarefoundation deleted a comment from stale Bot Dec 2, 2025
@autowarefoundation autowarefoundation deleted a comment from stale Bot Dec 2, 2025
@xmfcx xmfcx requested review from shmpwk and removed request for KhalilSelyan and shmpwk December 2, 2025 22:21
@xmfcx
Copy link
Copy Markdown
Contributor

xmfcx commented Dec 2, 2025

I'll update the images with the new rviz ui and test the instructions myself.

@xmfcx xmfcx marked this pull request as draft December 2, 2025 23:21
@xmfcx xmfcx self-assigned this Dec 2, 2025
@xmfcx xmfcx force-pushed the add-crosswalk-stop-tutorial branch from 1f1bdb5 to 9d6237d Compare December 3, 2025 11:37
@shmpwk
Copy link
Copy Markdown
Contributor

shmpwk commented Dec 4, 2025

Thank you so much 🙇

Ericpotato and others added 2 commits December 4, 2025 20:28
Signed-off-by: Ericpotato <zhanhong.yan@tier4.jp>
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx force-pushed the add-crosswalk-stop-tutorial branch 2 times, most recently from 60aa45b to 9611b8f Compare December 4, 2025 17:33
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx force-pushed the add-crosswalk-stop-tutorial branch from 9611b8f to 6db102c Compare December 4, 2025 17:46
@xmfcx xmfcx marked this pull request as ready for review December 4, 2025 17:47
Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx
Copy link
Copy Markdown
Contributor

xmfcx commented Dec 4, 2025

@Ericpotato and @shmpwk please check https://autowarefoundation.github.io/autoware-documentation/pr-514/demos/planning-simulation/#driving-through-a-crosswalk should be pretty much ready to merge now. Performed the tests multiple times.

@shmpwk the Experiment 2 at Signalized crosswalk was different than the older experiment.

The ego vehicle only has red light behavior after waiting for a while at the red light even if there is a pedestrian.

I have reflected the actual behavior in the demo guide.

Please review as soon as possible 🙇

@xmfcx xmfcx requested review from mitsudome-r and shmpwk December 4, 2025 18:08
@xmfcx
Copy link
Copy Markdown
Contributor

xmfcx commented Dec 4, 2025

In the future I will consider separating these mini-demos into some other section, separating them page by page. But for now let's focus on other priorities.

Copy link
Copy Markdown
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your help!
I confirmed the demonstration worked.

@xmfcx xmfcx merged commit 00732ad into autowarefoundation:main Dec 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants