Skip to content

feat(docker): add sensing/perception launch files to autoware:universe-sensing-perception images#5582

Merged
youtalk merged 6 commits intomainfrom
feat/sp-launch
Mar 21, 2025
Merged

feat(docker): add sensing/perception launch files to autoware:universe-sensing-perception images#5582
youtalk merged 6 commits intomainfrom
feat/sp-launch

Conversation

@youtalk
Copy link
Copy Markdown
Member

@youtalk youtalk commented Dec 19, 2024

Description

This PR makes it possible to run the autoware:universe-sensing-perception containers using the launch files designed for the components.

Ref. #5394

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk changed the title add sensing & perception launch feat(docker): add sensing/perception launch files to autoware:universe-sensing-perception images Dec 19, 2024
@youtalk youtalk self-assigned this Dec 19, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit run:health-check Run health-check labels Dec 19, 2024
@youtalk youtalk requested review from mitsudome-r and xmfcx December 19, 2024 07:32
@youtalk youtalk marked this pull request as draft March 12, 2025 13:33
@youtalk youtalk marked this pull request as ready for review March 16, 2025 23:54
@youtalk youtalk closed this Mar 17, 2025
@github-project-automation github-project-automation Bot moved this from Execution to Done in Open AD Kit Working Group Mar 17, 2025
@youtalk youtalk removed their assignment Mar 17, 2025
@youtalk youtalk reopened this Mar 17, 2025
@youtalk youtalk self-assigned this Mar 17, 2025
@youtalk
Copy link
Copy Markdown
Member Author

youtalk commented Mar 17, 2025

Due to #5881, the `health-checkfails whenrosdep keysfails. The fact that thehealth-check` passes even after adding the launch packages means that the dependency packages are satisfied.
@mitsudome-r @xmfcx @oguzkaganozt Please review this.

@youtalk
Copy link
Copy Markdown
Member Author

youtalk commented Mar 17, 2025

I accidentally closed it. Sorry.
@mitsudome-r This one is also review-ready.

@mitsudome-r
Copy link
Copy Markdown
Member

I will check locally if we can launch sensing/perception without an error with the built image.

Copy link
Copy Markdown
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I had to modify the perception_launch file slightly to run it independently, but the generated docker image contained all nodes that are necessary for launching.

@youtalk youtalk enabled auto-merge (squash) March 19, 2025 21:44
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk merged commit bd10e78 into main Mar 21, 2025
20 of 24 checks passed
@youtalk youtalk deleted the feat/sp-launch branch March 21, 2025 00:12
sykwer pushed a commit to sykwer/autoware that referenced this pull request Mar 22, 2025
…erse-sensing-perception` images (autowarefoundation#5582)

add sensing & perception launch

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: sykwer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:openadkit Issues or Features related to Open AD Kit run:health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants