refactor(Dockerfile): simplify --mount=type=bind options#5878
Merged
Conversation
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
youtalk
added
type:containers
mitsudome-r
approved these changes
Mar 14, 2025
1 task
sykwer
pushed a commit
to sykwer/autoware
that referenced
this pull request
Mar 22, 2025
…oundation#5878) simplify mount=type=bind options Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Signed-off-by: sykwer <sykwer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until now, files were mounted by specifying the stage name using the
--mount=type=bind,from=option, but this PR changes to mounting files from the host. This makes the mount option description simpler.It has also been confirmed that there is no negative impact on the image size:
How was this PR tested?
--mount=type=bindoptions youtalk/autoware#176Notes for reviewers
None.
Effects on system behavior
None.