fix(docker): fix and simplify visualizer container#6719
Open
oguzkaganozt wants to merge 4 commits intomainfrom
Open
fix(docker): fix and simplify visualizer container#6719oguzkaganozt wants to merge 4 commits intomainfrom
oguzkaganozt wants to merge 4 commits intomainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
oguzkaganozt
changed the title
oguzkaganozt
force-pushed
the
fix-and-simplify-visualizer
branch
from
31e8a20 to
20f32ee
Compare
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
oguzkaganozt
force-pushed
the
fix-and-simplify-visualizer
branch
from
20f32ee to
352eada
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes and simplifies the visualizer container as follows:
1- Visualizer container was missing required global parameters while launching autoware.rviz and fails to render plugins as shown in the image. With this PR, the Rviz will be launched using a launch file by including global parameters loader. Related issue: #6665
Even setting locale as explained here did not change the issue of missing parameters. @xmfcx
2- Base image changed to autoware:universe from autoware:universe-visualization since some rviz plugins were missing on universe-visualization
3- Dockerfile and the entrypoint script are simplified.
How was this PR tested?
After changes the visualizer container can sucessfully open rviz config files without error