Skip to content

fix(repositories): pin rviz_2d_overlay_plugins to 1.4.0#7020

Merged
xmfcx merged 1 commit intomainfrom
fix/pin-rviz-2d-overlay-plugins-1.4.0
Apr 15, 2026
Merged

fix(repositories): pin rviz_2d_overlay_plugins to 1.4.0#7020
xmfcx merged 1 commit intomainfrom
fix/pin-rviz-2d-overlay-plugins-1.4.0

Conversation

@xmfcx
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx commented Apr 15, 2026

Why

Upstream rviz_2d_overlay_plugins 1.4.1 (shipped as ros-jazzy-rviz-2d-overlay-plugins 1.4.1-1noble.20260412.050605 on packages.ros.org) has a broken AUTOMOC setup: librviz_2d_overlay_plugins.so ends up with undefined vtables for OverlayTextDisplay and PieChartDisplay, which breaks every downstream RViz plugin that links it — including rviz_plugins/Path, rviz_plugins/Trajectory, autoware_overlay_rviz_plugin/SignalDisplay, and several others across autoware_rviz_plugins. Upstream has merged the fix (teamspatzenhirn/rviz_2d_overlay_plugins#26) but not yet tagged a release (tracked at teamspatzenhirn/rviz_2d_overlay_plugins#27); pinning to the last known-good 1.4.0 unblocks everyone in the meantime.


Test plan

  • Import the pinned repo and build it:
    vcs import src < repositories/autoware.repos && source /opt/ros/jazzy/setup.bash && colcon build --symlink-install --packages-select rviz_2d_overlay_msgs rviz_2d_overlay_plugins --cmake-args -DCMAKE_BUILD_TYPE=Release
    
  • Confirm all four vtables are defined (V, not U):
    nm -D install/rviz_2d_overlay_plugins/lib/librviz_2d_overlay_plugins.so | grep _ZTVN23rviz_2d_overlay_plugins
    
    Expected: OverlayObject, OverlayTextDisplay, PieChartDisplay, ScopedPixelBuffer all marked V.
  • Launch the planning simulator and confirm no plugin-load errors:
    source /opt/ros/jazzy/setup.bash && source install/setup.bash && timeout 60 ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit 2>&1 | grep -c "PluginlibFactory.*failed to load"
    
    Expected: 0.
  • Revert this pin once upstream releases >=1.4.2 and apt serves the fixed package.

Upstream 1.4.1 ships a broken librviz_2d_overlay_plugins.so with
undefined vtables, which breaks every RViz plugin in autoware_rviz_plugins
that links it. Pin to the last known-good 1.4.0 under
core/external/rviz_2d_overlay_plugins until upstream cuts a new release.

See autowarefoundation/autoware_core#1031 for
details.

Signed-off-by: Mete Fatih Cırıt <[email protected]>
@xmfcx xmfcx requested a review from mitsudome-r as a code owner April 15, 2026 11:10
@xmfcx xmfcx self-assigned this Apr 15, 2026
@github-actions
Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx added the run:health-check Run health-check label Apr 15, 2026
@xmfcx xmfcx merged commit e01d46c into main Apr 15, 2026
21 of 22 checks passed
@xmfcx xmfcx deleted the fix/pin-rviz-2d-overlay-plugins-1.4.0 branch April 15, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants