ci(health-check-pr): always run, gate work via changed-files#7039
Merged
Conversation
Required status checks were blocked when the workflow's `paths:` filter excluded a PR: the check never appeared, so branch protection waited forever. Drop `paths:` and gate `require-label` (and transitively `health-check`) on `step-security/changed-files`. Skipped jobs satisfy required checks; missing workflows do not. Signed-off-by: Mete Fatih Cırıt <[email protected]>
xmfcx
requested review from
isamu-takagi,
oguzkaganozt and
youtalk
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull_request.paths:filter so the workflow triggers on every PRchanged-filesjob usingstep-security/changed-files@v47to detect whether any health-check-relevant path changedrequire-labelon the detection output;health-checkcascades vianeeds:Why
When a workflow used as a required status check has a trigger-level
paths:filter, GitHub does not trigger it on PRs that don't touch those paths. The required check then never appears, and branch protection blocks the PR forever. Skipped jobs satisfy required checks; missing workflows do not, so the workflow now always runs and skips internally instead..github/workflows/cleanup-actions-caches.yamland never triggeredhealth-check-pr, leaving the required check missingchanged-filesgate from a per-step check up to a trigger-levelpaths:filterTest plan
health-check-pr / changed-filesruns and succeedshealth-check-pr / require-labelshows as Skippedhealth-check-pr / health-checkshows as Skippeddocker-new/**,ansible/**, orrepositories/*.reposchanged-filesreportsany_changed=truerun:health-checklabel:require-labelfails,health-checkskipsrun:health-checklabel:require-labelpasses,health-checkruns the reusable workflowhealth-check-pr / health-check), not the workflow file itself — only per-job skipped checks count as success