ci(docker): remove orphaned composite actions from legacy pipeline#7042
Merged
ci(docker): remove orphaned composite actions from legacy pipeline#7042
Conversation
combine-multi-arch-images, derive-image-names, and docker-build were only ever used by the old docker-build-and-push* action family that #7040 removed. With the bake-based pipeline in place the manifest step is handled by docker-manifest.yaml, image names come from the tags() function in docker-bake.hcl, and the per-group build is a reusable workflow instead of a composite action. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/actions/that only the legacydocker-build-and-push*action family ever called:combine-multi-arch-images/,derive-image-names/,docker-build/. Grep foruses: ./.github/actions/{combine-multi-arch-images,derive-image-names,docker-build}returns zero hits across the tree..github/actions/contains onlyfree-disk-space/(still used by docker-build.yaml and health-check-reusable.yaml).Why
Each of these had a direct replacement baked into the new pipeline and the last caller went away in #7040:
combine-multi-arch-images— replaced by thedocker-manifest.yamlreusable workflow.derive-image-names— folded into thetags()function indocker/docker-bake.hcl.docker-build— superseded by thedocker-build.yamlreusable workflow (different namespace from the deleted action directory, no collision).Leaving them around is dead code that future readers will assume is shared.
Test plan
git grep -nE 'actions/(combine-multi-arch-images|derive-image-names|docker-build)([^/-]|$)'on this branch — empty.ls .github/actions/on this branch shows exactly one entry:free-disk-space/.docker-build-and-pushworkflow on the default push trigger (or a manualworkflow_dispatch) still resolves all itsuses:references and runs at least thehumble-amd64group to completion.