ci(codeowners): keep maintainers as owners for infra paths#7043
Merged
Conversation
CODEOWNERS uses last-match-wins with no owner merging, so the specific path rules were dropping mitsudome and mfc. Append them to each specific rule to retain coverage. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ryohsuke.mitsudome@tier4.jpandmfc@autoware.orgto the.devcontainer/**,.github/**,ansible/**, anddocker/**rules in .github/CODEOWNERS.Why
GitHub CODEOWNERS uses last-match-wins with no owner merging across matching lines (docs). The specific path rules were fully replacing the global
*owners, so changes underdocker/**,ansible/**, etc. stopped requesting review from the repo maintainers. Listing them explicitly on each specific rule restores coverage without weakening the per-path ownership.