Skip to content

refactor(ansible): rename internal playbooks to install_* prefix#7058

Merged
xmfcx merged 1 commit intomainfrom
feat/ansible-rename-internal-playbooks
Apr 24, 2026
Merged

refactor(ansible): rename internal playbooks to install_* prefix#7058
xmfcx merged 1 commit intomainfrom
feat/ansible-rename-internal-playbooks

Conversation

@xmfcx
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx commented Apr 24, 2026

Why

Phase 1 internal rename pass for the ansible entrypoint consolidation tracked in #7052. These three playbooks are only referenced from Dockerfiles in this repo, so renaming them is a pure internal refactor with no external impact — bundled into one PR because the three rename + Dockerfile update pairs are atomic (the file must match its referenced name for the build to succeed).

The survivor naming convention is `install_.yaml`, matching `install_dev_env.yaml` and `install_docker.yaml` that landed earlier in this effort.


Test plan

  • Lint passes:

    pre-commit run --all-files
  • No stale references remain anywhere in the repo:

    git grep -nE 'autoware_requirements|autoware\.dev_env\.(nvidia|rmw)\b|playbooks/(nvidia|rmw)\.yaml'

    Expect: no matches.

  • Bake builds the affected stages end-to-end on amd64:

    cd docker && docker buildx bake --set '*.platform=linux/amd64' ci-base ci-core ci-universe
    docker buildx bake --set '*.platform=linux/amd64' ci-base-cuda ci-universe-cuda

    Expect: each stage completes without `ansible-playbook: ERROR! the playbook ... could not be found` errors. The `base`, `base-cuda-`, `core-`, `universe-*` stages all exercise at least one of the renamed playbooks.

  • `health-check-ansible` workflow passes on this PR (runs `install_dev_env` directly on ubuntu-latest — unaffected by the renames, so this is a regression check for the ansible collection layout only).

  • `docker-build-and-push` workflow passes on this PR (full bake pipeline across jazzy + humble, amd64 + arm64).

Phase 1 internal rename pass for the ansible entrypoint consolidation
tracked in #7052.
These three playbooks are only referenced from Dockerfiles in this repo,
so renaming them is a pure internal refactor with no external impact.

- autoware_requirements.yaml -> install_image_deps.yaml
  (core.Dockerfile, universe.Dockerfile, universe-cuda.Dockerfile)
- nvidia.yaml -> install_nvidia.yaml
  (base-cuda.Dockerfile; updates both bind-mount paths and playbook names)
- rmw.yaml -> install_rmw.yaml
  (base.Dockerfile; updates bind-mount path and playbook name)

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx self-assigned this Apr 24, 2026
@xmfcx xmfcx requested a review from mitsudome-r as a code owner April 24, 2026 09:13
@github-actions
Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx xmfcx enabled auto-merge (squash) April 24, 2026 10:04
@xmfcx xmfcx merged commit 4309b45 into main Apr 24, 2026
34 of 36 checks passed
@xmfcx xmfcx deleted the feat/ansible-rename-internal-playbooks branch April 24, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants