refactor(ansible): rename internal playbooks to install_* prefix#7058
Merged
refactor(ansible): rename internal playbooks to install_* prefix#7058
Conversation
Phase 1 internal rename pass for the ansible entrypoint consolidation tracked in #7052. These three playbooks are only referenced from Dockerfiles in this repo, so renaming them is a pure internal refactor with no external impact. - autoware_requirements.yaml -> install_image_deps.yaml (core.Dockerfile, universe.Dockerfile, universe-cuda.Dockerfile) - nvidia.yaml -> install_nvidia.yaml (base-cuda.Dockerfile; updates both bind-mount paths and playbook names) - rmw.yaml -> install_rmw.yaml (base.Dockerfile; updates bind-mount path and playbook name) Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ansible/playbooks/to theinstall_*convention:autoware_requirements.yaml→install_image_deps.yaml,nvidia.yaml→install_nvidia.yaml,rmw.yaml→install_rmw.yaml.core.Dockerfile,universe.Dockerfile,universe-cuda.Dockerfile,base.Dockerfile,base-cuda.Dockerfile— bothansible-playbook autoware.dev_env.<name>call sites and the narrow--mount=type=bindpaths fornvidia.yaml/rmw.yaml.Why
Phase 1 internal rename pass for the ansible entrypoint consolidation tracked in #7052. These three playbooks are only referenced from Dockerfiles in this repo, so renaming them is a pure internal refactor with no external impact — bundled into one PR because the three rename + Dockerfile update pairs are atomic (the file must match its referenced name for the build to succeed).
The survivor naming convention is `install_.yaml`, matching `install_dev_env.yaml` and `install_docker.yaml` that landed earlier in this effort.
Test plan
Lint passes:
No stale references remain anywhere in the repo:
git grep -nE 'autoware_requirements|autoware\.dev_env\.(nvidia|rmw)\b|playbooks/(nvidia|rmw)\.yaml'Expect: no matches.
Bake builds the affected stages end-to-end on amd64:
Expect: each stage completes without `ansible-playbook: ERROR! the playbook ... could not be found` errors. The `base`, `base-cuda-`, `core-`, `universe-*` stages all exercise at least one of the renamed playbooks.
`health-check-ansible` workflow passes on this PR (runs `install_dev_env` directly on ubuntu-latest — unaffected by the renames, so this is a regression check for the ansible collection layout only).
`docker-build-and-push` workflow passes on this PR (full bake pipeline across jazzy + humble, amd64 + arm64).