docs(lanelet2_utils): add example usage to autoware_lanelet2_utils documentation#720
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
1a784bf to
bb1b9d4
Compare
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
fc622a7 to
08684e3
Compare
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 51.02% 51.77% +0.74%
==========================================
Files 335 350 +15
Lines 21481 26005 +4524
Branches 9776 12639 +2863
==========================================
+ Hits 10960 13463 +2503
- Misses 9482 11238 +1756
- Partials 1039 1304 +265
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
7026fc7 to
fb1e5c2
Compare
| find_package(yaml-cpp REQUIRED) | ||
| include_directories(${autoware_index_cpp_INCLUDE_DIRS}) | ||
| foreach(example_file ${example_files}) | ||
| get_filename_component(example_name ${example_file} NAME_WE) | ||
| ament_auto_add_executable(${example_name} | ||
| ${example_file} | ||
| ) | ||
| target_link_libraries(${example_name} | ||
| autoware_lanelet2_utils | ||
| ${autoware_index_cpp_LIBRARIES} | ||
| range-v3::range-v3 | ||
| Python3::Python |
There was a problem hiding this comment.
| find_package(yaml-cpp REQUIRED) | |
| include_directories(${autoware_index_cpp_INCLUDE_DIRS}) | |
| foreach(example_file ${example_files}) | |
| get_filename_component(example_name ${example_file} NAME_WE) | |
| ament_auto_add_executable(${example_name} | |
| ${example_file} | |
| ) | |
| target_link_libraries(${example_name} | |
| autoware_lanelet2_utils | |
| ${autoware_index_cpp_LIBRARIES} | |
| range-v3::range-v3 | |
| Python3::Python | |
| find_package(yaml-cpp REQUIRED) | |
| foreach(example_file ${example_files}) | |
| get_filename_component(example_name ${example_file} NAME_WE) | |
| ament_auto_add_executable(${example_name} | |
| ${example_file} | |
| ) | |
| ament_target_dependencies(${example_name} ament_index_cpp) | |
| target_link_libraries(${example_name} | |
| autoware_lanelet2_utils | |
| range-v3::range-v3 | |
| Python3::Python |
@sarun-hub sarun san
That will add compatibility for jazzy,
please consider this modification since ament_target_dependencies will take care include and lib automatically
There was a problem hiding this comment.
Thank you for your suggestion! I modify it to use ament_target_dependencies!
4fbbabb to
b77136a
Compare
39e9b3f to
1e970d2
Compare
|
@liuXinGangChina -san If you'd like to add ROS 2 Jazzy compatibility, could you please open a separate PR for that change? |
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
1e970d2 to
ab4da2d
Compare
Description
API table in
autoware_lanelet2_utilsis filled, but the example usages are not yet put in the documentation.This PR will add example files for putting example usage in documentation.
geometryconversionkindhatched_road_markingstopologyintersectionlane_sequencenn_searchmap_handlerroute_managerRelated links
Parent Issue:
How was this PR tested?
(ADDED by @sasakisasaki ) As this PR provides sample codes to show its usage, I believe once all the required CIs passed, it is sufficient as the tests.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.