feat: move sample description packages#799
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
|
Thanks Takagi-san, I'll review this along with the accompanying PRs tomorrow and report the results. They all should be merged at the same time. |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
2383600 to
4270833
Compare
There was a problem hiding this comment.
This PR adds autoware_ prefix to the following packages:
sample_sensor_kit_descriptionsample_vehicle_description
And that would require so many things to be refactored like:
Let's keep prefixing in a separate task.
Even if autoware builds with:
It won't run with these PRs because of the package name changes.
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…agi/autoware_core into feat/move-description-packages
|
@xmfcx Thank you for looking into the impact of the name change. It's OK for prefixed and non-prefixed packages to exist at the same time, and we should avoid renaming a package after merging it into autoware_core. So how about the following steps:
|
|
That would work 👍
|
|
@isamu-takagi -san thanks for the PRs.
Step 1 is completed. |
Description
Move the following description packages to release on ROS buildfarm.
Related links
Parent Issue:
How was this PR tested?
Check build and AWSIM demo with following PRs:
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.