Skip to content

feat: move sample description packages#799

Merged
xmfcx merged 4 commits intoautowarefoundation:mainfrom
isamu-takagi:feat/move-description-packages
Jan 20, 2026
Merged

feat: move sample description packages#799
xmfcx merged 4 commits intoautowarefoundation:mainfrom
isamu-takagi:feat/move-description-packages

Conversation

@isamu-takagi
Copy link
Copy Markdown
Contributor

@isamu-takagi isamu-takagi commented Jan 16, 2026

Description

Move the following description packages to release on ROS buildfarm.

  • sample_vehicle_description
  • sample_sensor_kit_description
  • awsim_sensor_kit_description

Related links

Parent Issue:

How was this PR tested?

Check build and AWSIM demo with following PRs:

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 16, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx
Copy link
Copy Markdown
Contributor

xmfcx commented Jan 16, 2026

Thanks Takagi-san, I'll review this along with the accompanying PRs tomorrow and report the results.

They all should be merged at the same time.

@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2026
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@xmfcx xmfcx force-pushed the feat/move-description-packages branch from 2383600 to 4270833 Compare January 19, 2026 17:17
Copy link
Copy Markdown
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds autoware_ prefix to the following packages:

  • sample_sensor_kit_description
  • sample_vehicle_description

And that would require so many things to be refactored like:

Let's keep prefixing in a separate task.


Even if autoware builds with:

It won't run with these PRs because of the package name changes.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…agi/autoware_core into feat/move-description-packages
@isamu-takagi
Copy link
Copy Markdown
Contributor Author

@xmfcx Thank you for looking into the impact of the name change.

It's OK for prefixed and non-prefixed packages to exist at the same time, and we should avoid renaming a package after merging it into autoware_core. So how about the following steps:

  1. Add prefixed packages
  2. Update documentation and related packages
  3. Remove non-prefixed package

@xmfcx
Copy link
Copy Markdown
Contributor

xmfcx commented Jan 20, 2026

That would work 👍

@xmfcx xmfcx merged commit 00d98c5 into autowarefoundation:main Jan 20, 2026
30 of 35 checks passed
@xmfcx
Copy link
Copy Markdown
Contributor

xmfcx commented Jan 20, 2026

@isamu-takagi -san thanks for the PRs.

Step 1 is completed.

@isamu-takagi isamu-takagi deleted the feat/move-description-packages branch January 21, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move sample description/launch packages to autoware_core

2 participants