refactor(autoware_lanelet2_extension): add USE_SCOPED_HEADER_INSTALL_DIR#105
Open
vish0012 wants to merge 1 commit intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 16.31% 22.72% +6.40%
==========================================
Files 42 46 +4
Lines 3089 3085 -4
Branches 1397 1707 +310
==========================================
+ Hits 504 701 +197
+ Misses 2490 2261 -229
- Partials 95 123 +28
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Need TIER IV Evaulator result or autoware docker image build result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
USE_SCOPED_HEADER_INSTALL_DIRto existingament_auto_package()calls inautoware_lanelet2_extension.Updated packages:
autoware_lanelet2_extensionautoware_lanelet2_extension_pythonHow was this PR tested?
Built the target packages locally:
colcon build --base-paths ~/autoware_scoped_headers/autoware/src \ --symlink-install \ --cmake-args -DCMAKE_BUILD_TYPE=Release \ --packages-select \ autoware_lanelet2_extension \ autoware_lanelet2_extension_pythonNotes for reviewers
This is part of the follow-up work after adding
USE_SCOPED_HEADER_INSTALL_DIRsupport toautoware_cmake.Interface changes
None.
Effects on system behavior
No functional behavior change. This updates the package macro options for the scoped header installation migration.