feat(planning_data_analyzer): add open-loop history comfort metric#379
Merged
go-sakayori merged 5 commits intoautowarefoundation:mainfrom Mar 30, 2026
Merged
Conversation
beomseok-kimm
requested review from
Dionysus326,
danielsanchezaran,
go-sakayori and
xtk8532704
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
go-sakayori
reviewed
Mar 27, 2026
Contributor
go-sakayori
left a comment
go-sakayori
left a comment
There was a problem hiding this comment.
Can you attach a link to the sample mcap and json?
| return time_diff > kFiniteDifferenceEpsilon ? time_diff : kFiniteDifferenceEpsilon; | ||
| } | ||
|
|
||
| double normalize_angle(const double angle) |
Contributor
There was a problem hiding this comment.
I assume there is a similar function in autoware_utils. Can you check?
Contributor
Author
There was a problem hiding this comment.
Added from autoware_utils
Contributor
Author
@go-sakayori |
go-sakayori
requested changes
Mar 30, 2026
beomseok-kimm
force-pushed
the
feat/epdms-hc-clean
branch
from
4a095ec to
01415ae
Compare
beomseok-kimm
force-pushed
the
feat/epdms-hc-clean
branch
from
01415ae to
e0a02fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first implementation step in a series toward full
EPDMSsupport inautoware_planning_data_analyzer, following theNAVSIMmetric definition and reference implementation:This PR specifically adds
HC (History Comfort)as the first standalone subscore.How was this PR tested?
Successfully created output rosbag that contains the HC topic.
Notes for reviewers
None.
Effects on system behavior
None.