feat(autoware_static_centerline_generator): replace autoware_universe_utils with specific autoware_utils sub-packages#411
Open
vish0012 wants to merge 2 commits intoautowarefoundation:mainfrom
Conversation
…_utils with specific autoware_utils sub-packages Migrates all autoware_universe_utils usages in the autoware_static_centerline_generator package to the specific autoware_utils sub-packages, as part of the autoware_universe_utils deprecation tracked in autowarefoundation/autoware_universe#12376. Changes: - package.xml: - <depend>autoware_universe_utils</depend> removed - Added <depend>autoware_utils_geometry</depend> - Added <depend>autoware_utils_math</depend> - Added <depend>autoware_utils_rclcpp</depend> - Added <depend>autoware_utils_visualization</depend> - Header includes swapped: - autoware/universe_utils/geometry/geometry.hpp -> autoware_utils_geometry/geometry.hpp - autoware/universe_utils/math/unit_conversion.hpp -> autoware_utils_math/unit_conversion.hpp - autoware/universe_utils/ros/parameter.hpp -> autoware_utils_rclcpp/parameter.hpp - autoware/universe_utils/ros/marker_helper.hpp -> autoware_utils_visualization/marker_helper.hpp - Geometry symbols (autoware_utils_geometry::): - Types: LinearRing2d, LineString2d, Point2d (names unchanged) - Functions renamed camelCase -> snake_case: - calcOffsetPose -> calc_offset_pose - calcAzimuthAngle -> calc_azimuth_angle - calcDistance2d -> calc_distance2d - createQuaternionFromYaw -> create_quaternion_from_yaw - Math symbols (autoware_utils_math::): - rad2deg (name unchanged) - RCLCPP symbols (autoware_utils_rclcpp::): - getOrDeclareParameter -> get_or_declare_parameter - Visualization symbols (autoware_utils_visualization::): - createDefaultMarker -> create_default_marker - createMarkerColor -> create_marker_color - createMarkerScale -> create_marker_scale Signed-off-by: github-actions <github-actions@github.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vish0012
added
tag:run-build-and-test-differential
and removed
component:planning
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
autoware_universe_utilsdependency in theautoware_static_centerline_generatorpackage with the specificautoware_utils_*sub-packages that are actually used, following the minimum-dependency principle.This package uses symbols from four different areas (geometry, math, ROS parameter, visualization), so it now depends on four specific sub-packages instead of the single umbrella package.
Changes
planning/autoware_static_centerline_generator/package.xml<depend>autoware_universe_utils</depend><depend>autoware_utils_geometry</depend><depend>autoware_utils_math</depend><depend>autoware_utils_rclcpp</depend><depend>autoware_utils_visualization</depend>Header include swaps
autoware/universe_utils/geometry/geometry.hpp→autoware_utils_geometry/geometry.hppautoware/universe_utils/math/unit_conversion.hpp→autoware_utils_math/unit_conversion.hppautoware/universe_utils/ros/parameter.hpp→autoware_utils_rclcpp/parameter.hppautoware/universe_utils/ros/marker_helper.hpp→autoware_utils_visualization/marker_helper.hppGeometry symbols →
autoware_utils_geometry::LinearRing2d,LineString2d,Point2dcalcOffsetPose→calc_offset_posecalcAzimuthAngle→calc_azimuth_anglecalcDistance2d→calc_distance2dcreateQuaternionFromYaw→create_quaternion_from_yawMath symbols →
autoware_utils_math::rad2deg(name unchanged)RCLCPP symbols →
autoware_utils_rclcpp::getOrDeclareParameter→get_or_declare_parameterVisualization symbols →
autoware_utils_visualization::createDefaultMarker→create_default_markercreateMarkerColor→create_marker_colorcreateMarkerScale→create_marker_scaleFiles touched:
package.xml,src/type_alias.hpp,src/static_centerline_generator_node.hpp,src/static_centerline_generator_node.cpp,src/centerline_source/bag_ego_trajectory_based_centerline.cpp,src/centerline_source/optimization_trajectory_based_centerline.cpp,src/utils.cpp.Related Issue
Part of the
autoware_universe_utilsdeprecation effort tracked in autowarefoundation/autoware_universe#12376 (theautoware_toolschecklist item).Additional notes
Part of a series of similar PRs for
autoware_tools, grouped by top-level directory: