feat(deviation_estimator): replace autoware_universe_utils with specific autoware_utils sub-packages#414
Open
vish0012 wants to merge 2 commits intoautowarefoundation:mainfrom
Conversation
…fic autoware_utils sub-packages Migrates all autoware_universe_utils usages in the deviation_estimator package to the specific autoware_utils sub-packages, as part of the autoware_universe_utils deprecation tracked in autowarefoundation/autoware_universe#12376. Changes: - package.xml: - <depend>autoware_universe_utils</depend> removed - Added <depend>autoware_utils_geometry</depend> - Added <depend>autoware_utils_math</depend> - Added <depend>autoware_utils_tf</depend> - Header includes swapped (in internal wrapper, source, and test files): - autoware/universe_utils/geometry/geometry.hpp -> autoware_utils_geometry/geometry.hpp - autoware/universe_utils/math/constants.hpp -> autoware_utils_math/constants.hpp - autoware/universe_utils/math/normalization.hpp -> autoware_utils_math/normalization.hpp - autoware/universe_utils/ros/transform_listener.hpp -> autoware_utils_tf/transform_listener.hpp - Geometry symbols (autoware_utils_geometry::): - getPose -> get_pose - getPoint -> get_point - getRPY -> get_rpy - createPoint -> create_point - calcAzimuthAngle -> calc_azimuth_angle - calcDistance2d -> calc_distance2d - calcElevationAngle -> calc_elevation_angle - createQuaternionFromRPY -> create_quaternion_from_rpy - Math symbols (autoware_utils_math::): - normalizeRadian -> normalize_radian - pi (name unchanged) - TF symbols (autoware_utils_tf::): - TransformListener (name unchanged) The internal wrapper header (include/deviation_estimator/autoware_universe_utils.hpp) keeps its filename since it is referenced by utils.hpp as the package's public-facing helper. Only its internal includes and symbol references are migrated. The tf2_ros::TransformListener in deviation_estimator.hpp is intentionally left unchanged as it is a tf2 API, not an autoware API. Signed-off-by: github-actions <github-actions@github.com>
vish0012
requested review from
Motsu-san,
TaikiYamada4 and
YamatoAndo
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
vish0012
added
tag:run-build-and-test-differential
and removed
component:localization
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the
autoware_universe_utilsdependency in thedeviation_estimatorpackage with the specificautoware_utils_*sub-packages that are actually used.Changes
package.xmlautoware_universe_utils; addedautoware_utils_geometry,autoware_utils_math,autoware_utils_tfHeader include swaps
autoware/universe_utils/geometry/geometry.hpp→autoware_utils_geometry/geometry.hppautoware/universe_utils/math/constants.hpp→autoware_utils_math/constants.hppautoware/universe_utils/math/normalization.hpp→autoware_utils_math/normalization.hppautoware/universe_utils/ros/transform_listener.hpp→autoware_utils_tf/transform_listener.hppSymbols
autoware_utils_geometry::—get_pose,get_point,get_rpy,create_point,calc_azimuth_angle,calc_distance2d,calc_elevation_angle,create_quaternion_from_rpyautoware_utils_math::—normalize_radian,piautoware_utils_tf::—TransformListenerNotes
include/deviation_estimator/autoware_universe_utils.hppkeeps its filename (it's referenced byutils.hpp); only its internal symbols are migrated.tf2_ros::TransformListenerindeviation_estimator.hppis a separate tf2 API and is left unchanged.Related Issue
Part of autowarefoundation/autoware_universe#12376 (
autoware_toolschecklist item).Additional notes
Part of a series of similar PRs for
autoware_tools, grouped by top-level directory: