fix(clang-tidy): re-enable bugprone-unused-local-non-trivial-variable

Re-enables bugprone-unused-local-non-trivial-variable in .clang-tidy-ci.

The check was suppressed in #12431 with 2 reported errors. This PR addresses both:

- autoware_manual_lane_change_handler: 'shift_unavailable_reason' was computed but never used in the subsequent log message. The fix appends it to the RCLCPP_INFO_STREAM so the log now reports the actual reason.

- autoware_behavior_path_side_shift_module: 'centerline_path' (line 211 of scene.cpp) was computed via utils::calcCenterLinePath but never used anywhere in the package. Dating from 2023, it appears to be leftover from a refactor. Removed the dead call.

Refs #12450

Signed-off-by: Vishal Chauhan <40782713+vish0012@users.noreply.github.com>

Author: vish0012

.clang-tidy-ci

@@ -18,7 +18,6 @@ Checks: "
   -bugprone-signed-char-misuse,
   -bugprone-switch-missing-default-case,
   -bugprone-unchecked-optional-access,
-  -bugprone-unused-local-non-trivial-variable,
   -bugprone-unused-return-value"
 
 WarningsAsErrors: "*"

planning/autoware_manual_lane_change_handler/src/manual_lane_change_handler.cpp

@@ -315,7 +315,8 @@ LaneChangeRequestResult ManualLaneChangeHandler::process_lane_change_request(
                                     : "next segment is right turn";
       RCLCPP_INFO_STREAM(
         logger_, "Cannot shift on the current segment (ID: "
-                   << current_segment.preferred_primitive.id << ")");
+                   << current_segment.preferred_primitive.id
+                   << "): " << shift_unavailable_reason);
       break;
     }
 

planning/behavior_path_planner/autoware_behavior_path_side_shift_module/src/scene.cpp

@@ -208,10 +208,6 @@ void SideShiftModule::updateData()
   if (getPreviousModuleOutput().reference_path.points.empty()) {
     return;
   }
-  const auto centerline_path = utils::calcCenterLinePath(
-    planner_data_, reference_pose, longest_dist_to_shift_line,
-    getPreviousModuleOutput().reference_path);
-
   constexpr double resample_interval = 1.0;
   const auto backward_extened_path = extendBackwardLength(getPreviousModuleOutput().path);
   reference_path_ = utils::resamplePathWithSpline(backward_extened_path, resample_interval);