fix(clang-tidy): re-enable clang-diagnostic-unused-but-set-variable

Signed-off-by: Vishal Chauhan <40782713+vish0012@users.noreply.github.com>

Author: vish0012

.clang-tidy-ci

@@ -30,5 +30,4 @@ ExtraArgs:
   - -Wno-deprecated-declarations
   - -Wno-delete-non-abstract-non-virtual-dtor
   - -Wno-unused-private-field
-  - -Wno-unused-but-set-variable
   - -Wno-deprecated-builtins

planning/motion_velocity_planner/autoware_motion_velocity_obstacle_slow_down_module/src/obstacle_slow_down_module.cpp

@@ -92,7 +92,7 @@ double find_reach_time(
   double upper = max;
   double t;
   int iter = 0;
-  for (int i = 0;; i++) {
+  for (;;) {
     t = 0.5 * (lower + upper);
     const double fx = f(t, j, a, v, d);
     // std::cout<<"fx: "<<fx<<" up: "<<upper<<" lo: "<<lower<<" t: "<<t<<std::endl;