Skip to content

Commit f8e95bc

Browse files
committed
refactor(autoware_traffic_light_visualization): inline marker namespace literal
The single-use kMarkerNamespace constant adds indirection without clarifying intent. Inline "traffic_light" at the assignment site so the namespace string is visible where it is set.
1 parent 5042c2e commit f8e95bc

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

perception/autoware_traffic_light_visualization/src/traffic_light_map_visualizer/traffic_light_visualizer.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
#include <utility>
2424
#include <vector>
2525

26-
constexpr char kMarkerNamespace[] = "traffic_light";
27-
2826
namespace
2927
{
3028

@@ -84,7 +82,7 @@ visualization_msgs::msg::Marker create_bulb_marker(
8482
marker.header.frame_id = "map";
8583
marker.header.stamp = stamp;
8684
marker.frame_locked = true;
87-
marker.ns = kMarkerNamespace;
85+
marker.ns = "traffic_light";
8886
marker.id = point.id();
8987
constexpr uint32_t marker_lifetime_ns = 200000000u;
9088
marker.lifetime.sec = 0;

0 commit comments

Comments
 (0)