Commit fb73b91
feat(trajectory_selector): combine validator and concatenator (#12532)
* feat(concatenator): add concatenator
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* feat: combine concatenator with validator
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: remove explicit find package, and pre-commit
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: failing test
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: create public interface for concatenator, and move concatenator to detail folder
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* feat: separate validator to validator interface and initialize selector
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix loading parameters
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix(node): publish validated trajectories; remove dead member and unjustified mutable
on_timer() computed the validated result but never called publish(), making
the node a no-op at the output. Both integration tests were silently timing
out because of this.
Also removed sub_trajectories_ which was declared but never assigned in
subscribers(), and dropped the unjustified `mutable` qualifier from
time_keeper_ (no const method ever writes to it).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix(validator_interface): use validator_ptr_ in validate_trajectories
validate_trajectories() was constructing a new TrajectoryValidator on
every call (copying the plugins_ vector each time) instead of using the
validator_ptr_ member that is initialized in the constructor for exactly
this purpose. validator_ptr_ was live memory that was never called.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix(validator_interface): remove redundant diagnostics clear; merge duplicate DebugPublisher
Two cleanups in validate_trajectories / publishers():
1. The first diagnostics_interface_ptr_->clear() was dead work: the
diagnostics are cleared again five lines later, just before the
add_key_value loop, so the first call never had observable effect.
2. pub_validation_reports_ and pub_debug_ were both initialized to a
DebugPublisher with the identical prefix "~/debug". A single
DebugPublisher handles multiple sub-topics; the duplicate object
added confusion without benefit. Removed pub_validation_reports_ and
routed its one call-site through pub_debug_.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: add test
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: rename context
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* style(pre-commit): autofix
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: return if concatenated is empty
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* doc: docstring
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: remove failed spellcheck
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix initial processing time value
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* fix: rename interface to wrapper
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* remove processing time and add unit test
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* style(pre-commit): autofix
* separate trajectory selector
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: precommit
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* readme
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: addresses copilot comments
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix: address minor copilot comment
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
---------
Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>1 parent 62be9cd commit fb73b91
36 files changed
Lines changed: 1833 additions & 719 deletions
File tree
- planning
- autoware_trajectory_concatenator
- config
- include/autoware/trajectory_concatenator
- detail
- launch
- src
- detail
- test
- autoware_trajectory_selector
- include/autoware/trajectory_selector
- launch
- schema
- src
- test
- dummy_plugin
- node
- autoware_trajectory_validator
- include/autoware/trajectory_validator
- detail
- schema
- src
- detail
Lines changed: 22 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | 11 | | |
16 | | - | |
| 12 | + | |
17 | 13 | | |
18 | 14 | | |
19 | 15 | | |
20 | 16 | | |
21 | 17 | | |
22 | 18 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 70 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
Lines changed: 96 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
Lines changed: 0 additions & 12 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
Lines changed: 97 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
0 commit comments