Fix supressed clang-tidy failures

[xmfcx]

• Fix clang-tidy errors supressed by fix(ci): resolve clang-tidy failures on main branch #12431

This issue aims to reopen these checks by fixing the failures.

Affected packages by check

bugprone-unchecked-optional-access (284 errors)

Package	Errors
common/autoware_universe_utils	70
planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module	41
planning/behavior_velocity_planner/autoware_behavior_velocity_roundabout_module	18
evaluator/autoware_planning_evaluator	15
planning/behavior_velocity_planner/autoware_behavior_velocity_crosswalk_module	12
planning/autoware_freespace_planning_algorithms	11
planning/behavior_path_planner/autoware_behavior_path_goal_planner_module	9
planning/motion_velocity_planner/autoware_motion_velocity_run_out_module	7
sensing/autoware_imu_corrector	7
simulator/autoware_dummy_perception_publisher	7
planning/behavior_path_planner/autoware_behavior_path_planner	6
planning/behavior_velocity_planner/autoware_behavior_velocity_blind_spot_module	6
planning/sampling_based_planner/autoware_frenet_planner	6
localization/yabloc/yabloc_image_processing	4
planning/behavior_path_planner/autoware_behavior_path_bidirectional_traffic_module	4
planning/motion_velocity_planner/autoware_motion_velocity_out_of_lane_module	4
planning/motion_velocity_planner/autoware_motion_velocity_road_user_stop_module	4
vehicle/autoware_steer_offset_estimator	4
perception/autoware_lidar_frnet	3
planning/autoware_path_optimizer	3
planning/behavior_path_planner/autoware_behavior_path_lane_change_module	3
planning/motion_velocity_planner/autoware_motion_velocity_obstacle_slow_down_module	3
planning/planning_validator/autoware_planning_validator_trajectory_checker	3
system/autoware_processing_time_checker	3
control/autoware_predicted_path_checker	2
localization/yabloc/yabloc_particle_filter	2
planning/autoware_mission_planner_universe	2
planning/behavior_path_planner/autoware_behavior_path_dynamic_obstacle_avoidance_module	2
planning/behavior_path_planner/autoware_behavior_path_start_planner_module	2
planning/behavior_velocity_planner/autoware_behavior_velocity_virtual_traffic_light_module	2
planning/motion_velocity_planner/autoware_motion_velocity_dynamic_obstacle_stop_module	2
sensing/autoware_pointcloud_preprocessor	2
system/autoware_command_mode_decider	2
14 packages with 1 error each	14

bugprone-assignment-in-if-condition (45 errors)

Package	Errors
planning/autoware_freespace_planning_algorithms	39
perception/autoware_bytetrack	6

clang-diagnostic-deprecated-declarations (21 errors)

All from dependency header autoware_component_interface_utils (service_server.hpp / service_client.hpp) using deprecated rmw_qos_profile_t API. Not autoware_universe source code.

bugprone-optional-value-conversion (20 errors)

Package	Errors
planning/behavior_velocity_planner/autoware_behavior_velocity_intersection_module	7
planning/behavior_path_planner/autoware_behavior_path_dynamic_obstacle_avoidance_module	4
planning/behavior_velocity_planner/autoware_behavior_velocity_crosswalk_module	2
planning/motion_velocity_planner/autoware_motion_velocity_road_user_stop_module	2
5 packages with 1 error each	5

bugprone-switch-missing-default-case (6 errors)

Package	Errors
control/autoware_operation_mode_transition_manager	1
perception/autoware_lidar_apollo_instance_segmentation	1
simulator/autoware_dummy_perception_publisher	1
system/autoware_command_mode_switcher	1
system/autoware_default_adapi_universe	1
visualization/tier4_planning_factor_rviz_plugin	1

clang-diagnostic-delete-non-abstract-non-virtual-dtor (4 errors)

All from perception/autoware_lidar_apollo_instance_segmentation (FeatureMap classes with virtual functions but non-virtual destructor).

bugprone-multi-level-implicit-pointer-conversion (3 errors)

Package	Errors
e2e/autoware_tensorrt_vad	2
common/autoware_universe_utils	1

bugprone-empty-catch (3 errors)

Package	Errors
localization/yabloc/yabloc_common	1
system/autoware_default_adapi_helpers/autoware_automatic_pose_initializer	1
visualization/tier4_planning_factor_rviz_plugin	1

bugprone-unused-return-value (2 errors)

Package	Errors
system/autoware_system_monitor	2

bugprone-unused-local-non-trivial-variable (2 errors)

Package	Errors
planning/autoware_manual_lane_change_handler	1
planning/behavior_path_planner/autoware_behavior_path_side_shift_module	1

clang-diagnostic-unused-private-field (2 errors)

Package	Errors
perception/autoware_lidar_apollo_instance_segmentation	2

clang-diagnostic-unused-but-set-variable (1 error)

Package	Errors
planning/motion_velocity_planner/autoware_motion_velocity_obstacle_slow_down_module	1

clang-diagnostic-deprecated-builtins (1 error)

Package	Errors
sensing/autoware_pointcloud_preprocessor	1

[mitsudome-r]

How to reproduce:

• Run colcon build
• run : run-clang-tidy -p build/ -export-fixes /tmp/clang-tidy-result/fixes.yaml -j $(nproc) <target_files> > /tmp/clang-tidy-result/report.log