Skip to content
This repository was archived by the owner on Mar 28, 2025. It is now read-only.

Conversation

@vividf
Copy link
Contributor

@vividf vividf commented Jun 11, 2024

Description

The previous parameter output_frame in ring outlier filter will always change from base_link back to sensor_frame because the if LaunchConfiguration("output_as_sensor_frame").perform(context) is always true.

That is because LaunchConfiguration("output_as_sensor_frame").perform(context) is a string.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf vividf requested a review from YoshiRi June 11, 2024 06:14
@vividf vividf self-assigned this Jun 11, 2024
@vividf vividf requested a review from TaikiYamada4 June 11, 2024 06:25
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@vividf vividf merged commit a74a6cc into autowarefoundation:main Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants