Merged
Conversation
Contributor
Author
|
Closes #118 |
christopherbrumm
force-pushed
the
christopher/amino-codec
branch
from
8770bdb to
8567f65
Compare
mbreithecker
previously approved these changes
Jan 22, 2026
# Conflicts: # x/core/module.go
There was a problem hiding this comment.
Pull request overview
This PR corrects several naming inconsistencies in amino type registrations and protobuf comments across the codebase. The changes ensure that type names accurately reflect the message types they represent, improving code clarity and maintainability.
Changes:
- Fixed amino name registrations to match actual message type names
- Corrected protobuf comment documentation to accurately describe message types
- Removed outdated TODO comments about duplicate registrations
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| x/core/02_post_dispatch/types/tx.pb.go | Updated comments to correctly identify MsgSetIgpOwnerResponse, MsgCreateMerkleTreeHook, MsgCreateNoopHook, and MsgCreateNoopHookResponse |
| x/core/02_post_dispatch/module.go | Fixed amino registration name from "MsgCreateInterchainGasPaymaster" to "MsgCreateIgp" and added registration for MsgCreateNoopHook |
| x/core/01_interchain_security/types/tx.pb.go | Updated comments to correctly identify MsgCreateMerkleRootMultisigIsm and MsgCreateMerkleRootMultisigIsmResponse |
| x/core/01_interchain_security/module.go | Fixed typo in amino registration for MsgSetRoutingIsmDomain |
| proto/hyperlane/core/post_dispatch/v1/tx.proto | Corrected amino name and comment documentation for multiple message types |
| proto/hyperlane/core/interchain_security/v1/tx.proto | Fixed comments and amino name for MsgSetRoutingIsmDomain |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yjamin
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes naming typos.