Content: Add MADFLIGHT_FC3 board doc #622
Conversation
WalkthroughAdds a new MDX documentation page for the MADFLIGHT_FC3 flight controller with front-matter metadata, a Specifications tab (SpecGrid), Photos tab, detailed I/O and sensor listings, and three connector/pin‑header sections with explicit pin mappings and images. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-09-24T20:59:20.784ZApplied to files:
📚 Learning: 2025-09-24T21:00:01.780ZApplied to files:
🪛 LanguageTooldocs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx[style] ~93-~93: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”. | Pin Number | GPIO | Signal Name | (PIN_NUMBER) [style] ~114-~114: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”. | Pin Number | GPIO | Signal Name | (PIN_NUMBER) [style] ~135-~135: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”. | Pin Number | GPIO | Signal Name | (PIN_NUMBER) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (1)
20-20: Consider title casing for consistency with board designation.Line 20 uses lowercase "madflight" while the board is designated "MADFLIGHT_FC3" elsewhere (front matter, specs). Verify the intended presentation style for this title.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3-images/MADFLIGHT_FC3-bottom.pngis excluded by!**/*.pngdocs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3-images/MADFLIGHT_FC3-top.pngis excluded by!**/*.png
📒 Files selected for processing (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
🧰 Additional context used
🪛 GitHub Actions: Deployment
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
[error] 162-162: MDX compilation failed: Unexpected closing tag , expected corresponding closing tag for (end-tag-mismatch).
🪛 LanguageTool
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
[style] ~93-~93: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - First Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~114-~114: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ...### 2.54mm Pin Header - Second Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~135-~135: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - Thrid Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
🔇 Additional comments (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (1)
109-110: Clarify inconsistent pin numbering convention.Pin rows use "A5" for rows labeled "| A5 | 3.3V |" (lines 109, 130, 151) while other pins are numbered sequentially (1–19, 1–19, 1–43). Confirm whether "A5" is intentional (e.g., a silkscreen label) or should be "15" for consistency with numeric row sequencing. If intentional, consider adding a note explaining the labeling scheme.
Also applies to: 130-131, 151-152
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (1)
133-133: Fix typo: "Thrid" → "Third".This typo was flagged in a previous review but remains unfixed.
🔎 Proposed fix
-### 2.54mm Pin Header - Thrid Row +### 2.54mm Pin Header - Third Row
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-24T20:59:20.784Z
Learnt from: VitroidFPV
Repo: betaflight/betaflight.com PR: 567
File: docs/wiki/guides/current/SoftSerial.md:129-133
Timestamp: 2025-09-24T20:59:20.784Z
Learning: In Betaflight firmware 4.5.2 and higher, the correct CLI syntax for SoftSerial resources uses underscores: `RESOURCE SOFTSERIAL_TX <index> <pin>` and `RESOURCE SOFTSERIAL_RX <index> <pin>`. The release notes in docs/wiki/release/Betaflight-4-5-Release-Notes.md incorrectly show the format without underscores (SOFTSERIALTX/SOFTSERIALRX) and should be corrected to match the authoritative CLI syntax documented in docs/development/Serial.md.
Applied to files:
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
🪛 GitHub Actions: Deployment
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
[error] 1-1: MDX compilation failed. Image docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3-images/MADFLIGHT_FC3_top.png used in MADFLIGHT_FC3.mdx not found.
🪛 LanguageTool
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
[style] ~93-~93: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - First Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~114-~114: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ...### 2.54mm Pin Header - Second Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~135-~135: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - Thrid Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
🔇 Additional comments (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (1)
109-109: Verify pin numbering: "A5" in Pin Number column.All three pin header tables use "A5" in the Pin Number column (rows 15), which breaks the sequential numbering pattern (1-16). If this refers to an analog pin designation, consider clarifying this in a note or confirming whether it should be "15" instead.
Also applies to: 130-130, 151-151
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (1)
163-163: Consider using spaces instead of tab for consistency.Line 163 contains a tab character before the closing tag. For consistency with the rest of the file, consider using spaces for indentation.
🔎 Proposed fix
- </TabItem> +</TabItem>
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-24T20:59:20.784Z
Learnt from: VitroidFPV
Repo: betaflight/betaflight.com PR: 567
File: docs/wiki/guides/current/SoftSerial.md:129-133
Timestamp: 2025-09-24T20:59:20.784Z
Learning: In Betaflight firmware 4.5.2 and higher, the correct CLI syntax for SoftSerial resources uses underscores: `RESOURCE SOFTSERIAL_TX <index> <pin>` and `RESOURCE SOFTSERIAL_RX <index> <pin>`. The release notes in docs/wiki/release/Betaflight-4-5-Release-Notes.md incorrectly show the format without underscores (SOFTSERIALTX/SOFTSERIALRX) and should be corrected to match the authoritative CLI syntax documented in docs/development/Serial.md.
Applied to files:
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
🪛 LanguageTool
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
[style] ~93-~93: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - First Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~114-~114: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ...### 2.54mm Pin Header - Second Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~135-~135: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - Third Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy
🔇 Additional comments (3)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (3)
1-21: LGTM!Front matter metadata and component imports are properly structured.
156-162: LGTM!Photos tab structure is correct. Image file verification is covered in the earlier comment.
28-28: Images have been restored to the repository.The previously missing image files
MADFLIGHT_FC3-top.pngandMADFLIGHT_FC3-bottom.pngare now present in theMADFLIGHT_FC3-images/directory and will render correctly without MDX compilation errors.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (1)
93-93: Optional: Consider shortening "Pin Number" to "Pin".The static analysis tool suggests that "Pin Number" is slightly redundant since "N" in "Pin" already implies "number". You could optionally shorten the column header to just "Pin" in all three tables (lines 93, 114, and 135) for brevity.
This is a very minor style suggestion and not critical.
🔎 Optional refactor for all three tables
-| Pin Number | GPIO | Signal Name | +| Pin | GPIO | Signal Name |Apply the same change at lines 114 and 135.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-24T20:59:20.784Z
Learnt from: VitroidFPV
Repo: betaflight/betaflight.com PR: 567
File: docs/wiki/guides/current/SoftSerial.md:129-133
Timestamp: 2025-09-24T20:59:20.784Z
Learning: In Betaflight firmware 4.5.2 and higher, the correct CLI syntax for SoftSerial resources uses underscores: `RESOURCE SOFTSERIAL_TX <index> <pin>` and `RESOURCE SOFTSERIAL_RX <index> <pin>`. The release notes in docs/wiki/release/Betaflight-4-5-Release-Notes.md incorrectly show the format without underscores (SOFTSERIALTX/SOFTSERIALRX) and should be corrected to match the authoritative CLI syntax documented in docs/development/Serial.md.
Applied to files:
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
📚 Learning: 2025-09-24T21:00:01.780Z
Learnt from: VitroidFPV
Repo: betaflight/betaflight.com PR: 567
File: docs/wiki/release/Betaflight-4-5-Release-Notes.md:364-364
Timestamp: 2025-09-24T21:00:01.780Z
Learning: VitroidFPV (project contributor) corrected that SOFTSERIAL_RX (with underscore) is the correct CLI format as of firmware 4.5.2, not SOFTSERIALTX/SOFTSERIALRX (without underscore) as shown in the release notes.
Applied to files:
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
🪛 LanguageTool
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx
[style] ~93-~93: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - First Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~114-~114: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ...### 2.54mm Pin Header - Second Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
[style] ~135-~135: This phrase is redundant (‘N’ stands for ‘number’). Consider using “Pin”.
Context: ... ### 2.54mm Pin Header - Third Row
| Pin Number | GPIO | Signal Name |
| ---------- | ...
(PIN_NUMBER)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy
🔇 Additional comments (1)
docs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3.mdx (1)
28-28: Image files are present in the repository.The referenced image files (
MADFLIGHT_FC3-top.pngandMADFLIGHT_FC3-bottom.png) exist indocs/wiki/boards/current/MADFLIGHT_FC3/MADFLIGHT_FC3-images/with correct sizes (1.3 MB and 1.4 MB respectively). The documentation images are properly in place.Likely an incorrect or invalid review comment.
|
4 participants
No description provided.