-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Initial raytraced lighting progress (bevy_solari) #19058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 84 commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
e28c8c8
WIP
JMS55 f42c25b
Add logo
JMS55 58507ba
Guard extra buffer usages behind a cargo feature
JMS55 fdf123f
Better pattern to contain RT buffer usages entirely within bevy_solari
JMS55 f9e5aa2
Add extra mesh allocator buffer usages instead of overwriting
JMS55 cfb1ba2
Merge commit '301f61845a26107ab36f83d2702f471642be25b1' into solari6
JMS55 92997a0
Add BLAS creation code
JMS55 7224fcd
WIP scene bindings
JMS55 e7b9aa5
Add binding array helpers
JMS55 c9dd3ab
WIP scene binder
JMS55 c635e31
WIP scene binding
JMS55 182e88b
WIP example setup
JMS55 27abb14
Misc
JMS55 135bcb4
Bugfix
JMS55 e9ea256
WIP pathtracer
JMS55 324f1be
Fix?
JMS55 491effd
Switch to uploading geometry slices instead of descriptors
JMS55 60d86b3
Fixes
JMS55 e60addf
Use patched naga_oil
JMS55 e387883
Scene binder WIP
JMS55 231ca08
Simplify code
JMS55 0b0db2c
Add material bindings
JMS55 5ff7c4d
Misc reorder
JMS55 7ebea4a
Fix mesh binding array shader types
JMS55 45bd908
Merge commit '73f03327c234f935ba7328220f6a25e3b33e1899' into solari6
JMS55 f0e13b2
Note down some bugs
JMS55 f2873c0
Note that RaytracingMesh3d cannot be used standalone
JMS55 c8eddb3
Add missing import
JMS55 6e78a94
Reset pathtracer accumulation on view
JMS55 d4e4dba
Hide modules
JMS55 5959cdd
Add light source data to the scene
JMS55 6804f61
Add missing bindings
JMS55 757c1e5
Add enable_raytracing flag to Mesh, misc other changes
JMS55 f89e2f7
Merge commit '18e1bf1c3ddf6b102a416b4886b40c025e800cd6' into solari6
JMS55 4f5a2ec
Fix merge
JMS55 18cb7fc
Remove Mesh3d to skip raster rendering when pathtracer is on
JMS55 305c015
Basic pathtracer
JMS55 4354944
Misc
JMS55 123628a
Add emissive mesh sampling utilities
JMS55 63272d1
Bugfixes
JMS55 1f051f8
Add NEE for emissive meshes
JMS55 4005334
Implement support for directional lights (seems too dim though)
JMS55 7bc608f
Rename irradiance to radiance in the path tracer, since it's a single…
JMS55 b9134ee
Adjust RAY_T_MIN
JMS55 5f79f7a
Fix directional light units
JMS55 4c6abfe
Misc
JMS55 49166b1
Rename directional light color to illuminance
JMS55 a4ef1f0
Merge commit 'cd67bac544a874f668c706b837c8b3093dfb9545' into solari6
JMS55 044474a
Make sun size configurable
JMS55 f26e0c1
Fix incorrect throughput calculation, add comments
JMS55 7dc5458
Remove russian roulette bias
JMS55 d25d52e
Change example clear color for raster
JMS55 9adcdd0
Misc
JMS55 2dc2589
Add release notes
JMS55 eb48343
Fix release notes
JMS55 d80f376
Fix overflows with high sample counts
JMS55 7753735
Specify commit of forked naga_oil
JMS55 51c5f56
Update crates/bevy_solari/src/pathtracer/node.rs
JMS55 86f2aa2
Add more docs to Mesh::enable_raytracing
JMS55 c5e178a
Merge commit '45ba5b9f0347710d0b84979631fae6f690434d62' into solari6
JMS55 a31e549
Misc
JMS55 f83a666
CI fixes
JMS55 e070d7b
Doc fmt
JMS55 569b85d
CI fixes
JMS55 45bcffd
Update to naga_oil 0.17.1
JMS55 1f21410
Misc rename
JMS55 8ab295a
Simplify BGL code
JMS55 948dfa9
Misc rename
JMS55 a3f9edb
Merge commit '523600133d92ee55f94d8184636787fd33845dd3' into solari6
JMS55 01465b5
Fix HDR usage after rebase
JMS55 3c18ea2
Use new embedded shader asset APIs
JMS55 bee4d51
New sampling APIs
JMS55 def2300
Misc
JMS55 ef1f736
Misc
JMS55 31f7a49
Emissive mesh bugfixes
JMS55 a700bd3
Add back cos_theta_light clamp
JMS55 87d8d30
Misc
JMS55 af4c61e
Update release-content/release-notes/bevy_solari.md
JMS55 f631771
Merge commit '56f26cfb022433ad16f7078e9f0a8de5f5cbcc3b' into solari6
JMS55 057c2f7
Merge branch 'main' into solari6
JMS55 0bbd643
Fix rebase
JMS55 4abdd78
Doc improvement
JMS55 78ff61d
Merge branch 'main' into solari6
JMS55 c3ed106
Merge branch 'main' into solari6
JMS55 36c5f99
Rename RaytracingScene -> SolariScene
JMS55 30cb322
Remove extra stuff in svg
JMS55 433a29a
Add some docs
JMS55 3309e33
Use the existing cornell box scene
JMS55 9043d58
Misc
JMS55 4c8ce14
Fix doc
JMS55 04b426c
Merge remote-tracking branch 'origin/main' into pr/JMS55/19058
cart fc7defe
Trigger -> On
cart 8e6a076
"solari scene" -> "raytracing scene"
cart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| [package] | ||
| name = "bevy_solari" | ||
cart marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| version = "0.16.0-dev" | ||
| edition = "2024" | ||
| description = "Provides raytraced lighting for Bevy Engine" | ||
| homepage = "https://bevyengine.org" | ||
| repository = "https://github.com/bevyengine/bevy" | ||
| license = "MIT OR Apache-2.0" | ||
| keywords = ["bevy"] | ||
|
|
||
| [dependencies] | ||
| # bevy | ||
| bevy_app = { path = "../bevy_app", version = "0.16.0-dev" } | ||
| bevy_asset = { path = "../bevy_asset", version = "0.16.0-dev" } | ||
| bevy_color = { path = "../bevy_color", version = "0.16.0-dev" } | ||
| bevy_core_pipeline = { path = "../bevy_core_pipeline", version = "0.16.0-dev" } | ||
| bevy_derive = { path = "../bevy_derive", version = "0.16.0-dev" } | ||
| bevy_ecs = { path = "../bevy_ecs", version = "0.16.0-dev" } | ||
| bevy_math = { path = "../bevy_math", version = "0.16.0-dev" } | ||
| bevy_mesh = { path = "../bevy_mesh", version = "0.16.0-dev" } | ||
| bevy_pbr = { path = "../bevy_pbr", version = "0.16.0-dev" } | ||
| bevy_platform = { path = "../bevy_platform", version = "0.16.0-dev", default-features = false, features = [ | ||
| "std", | ||
| ] } | ||
| bevy_reflect = { path = "../bevy_reflect", version = "0.16.0-dev" } | ||
| bevy_render = { path = "../bevy_render", version = "0.16.0-dev" } | ||
| bevy_transform = { path = "../bevy_transform", version = "0.16.0-dev" } | ||
|
|
||
| # other | ||
| tracing = { version = "0.1", default-features = false, features = ["std"] } | ||
| derive_more = { version = "1", default-features = false, features = ["from"] } | ||
|
|
||
| [lints] | ||
| workspace = true | ||
|
|
||
| [package.metadata.docs.rs] | ||
| rustdoc-args = ["-Zunstable-options", "--generate-link-to-definition"] | ||
| all-features = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,176 @@ | ||
| Apache License | ||
| Version 2.0, January 2004 | ||
| http://www.apache.org/licenses/ | ||
|
|
||
| TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION | ||
|
|
||
| 1. Definitions. | ||
|
|
||
| "License" shall mean the terms and conditions for use, reproduction, | ||
| and distribution as defined by Sections 1 through 9 of this document. | ||
|
|
||
| "Licensor" shall mean the copyright owner or entity authorized by | ||
| the copyright owner that is granting the License. | ||
|
|
||
| "Legal Entity" shall mean the union of the acting entity and all | ||
| other entities that control, are controlled by, or are under common | ||
| control with that entity. For the purposes of this definition, | ||
| "control" means (i) the power, direct or indirect, to cause the | ||
| direction or management of such entity, whether by contract or | ||
| otherwise, or (ii) ownership of fifty percent (50%) or more of the | ||
| outstanding shares, or (iii) beneficial ownership of such entity. | ||
|
|
||
| "You" (or "Your") shall mean an individual or Legal Entity | ||
| exercising permissions granted by this License. | ||
|
|
||
| "Source" form shall mean the preferred form for making modifications, | ||
| including but not limited to software source code, documentation | ||
| source, and configuration files. | ||
|
|
||
| "Object" form shall mean any form resulting from mechanical | ||
| transformation or translation of a Source form, including but | ||
| not limited to compiled object code, generated documentation, | ||
| and conversions to other media types. | ||
|
|
||
| "Work" shall mean the work of authorship, whether in Source or | ||
| Object form, made available under the License, as indicated by a | ||
| copyright notice that is included in or attached to the work | ||
| (an example is provided in the Appendix below). | ||
|
|
||
| "Derivative Works" shall mean any work, whether in Source or Object | ||
| form, that is based on (or derived from) the Work and for which the | ||
| editorial revisions, annotations, elaborations, or other modifications | ||
| represent, as a whole, an original work of authorship. For the purposes | ||
| of this License, Derivative Works shall not include works that remain | ||
| separable from, or merely link (or bind by name) to the interfaces of, | ||
| the Work and Derivative Works thereof. | ||
|
|
||
| "Contribution" shall mean any work of authorship, including | ||
| the original version of the Work and any modifications or additions | ||
| to that Work or Derivative Works thereof, that is intentionally | ||
| submitted to Licensor for inclusion in the Work by the copyright owner | ||
| or by an individual or Legal Entity authorized to submit on behalf of | ||
| the copyright owner. For the purposes of this definition, "submitted" | ||
| means any form of electronic, verbal, or written communication sent | ||
| to the Licensor or its representatives, including but not limited to | ||
| communication on electronic mailing lists, source code control systems, | ||
| and issue tracking systems that are managed by, or on behalf of, the | ||
| Licensor for the purpose of discussing and improving the Work, but | ||
| excluding communication that is conspicuously marked or otherwise | ||
| designated in writing by the copyright owner as "Not a Contribution." | ||
|
|
||
| "Contributor" shall mean Licensor and any individual or Legal Entity | ||
| on behalf of whom a Contribution has been received by Licensor and | ||
| subsequently incorporated within the Work. | ||
|
|
||
| 2. Grant of Copyright License. Subject to the terms and conditions of | ||
| this License, each Contributor hereby grants to You a perpetual, | ||
| worldwide, non-exclusive, no-charge, royalty-free, irrevocable | ||
| copyright license to reproduce, prepare Derivative Works of, | ||
| publicly display, publicly perform, sublicense, and distribute the | ||
| Work and such Derivative Works in Source or Object form. | ||
|
|
||
| 3. Grant of Patent License. Subject to the terms and conditions of | ||
| this License, each Contributor hereby grants to You a perpetual, | ||
| worldwide, non-exclusive, no-charge, royalty-free, irrevocable | ||
| (except as stated in this section) patent license to make, have made, | ||
| use, offer to sell, sell, import, and otherwise transfer the Work, | ||
| where such license applies only to those patent claims licensable | ||
| by such Contributor that are necessarily infringed by their | ||
| Contribution(s) alone or by combination of their Contribution(s) | ||
| with the Work to which such Contribution(s) was submitted. If You | ||
| institute patent litigation against any entity (including a | ||
| cross-claim or counterclaim in a lawsuit) alleging that the Work | ||
| or a Contribution incorporated within the Work constitutes direct | ||
| or contributory patent infringement, then any patent licenses | ||
| granted to You under this License for that Work shall terminate | ||
| as of the date such litigation is filed. | ||
|
|
||
| 4. Redistribution. You may reproduce and distribute copies of the | ||
| Work or Derivative Works thereof in any medium, with or without | ||
| modifications, and in Source or Object form, provided that You | ||
| meet the following conditions: | ||
|
|
||
| (a) You must give any other recipients of the Work or | ||
| Derivative Works a copy of this License; and | ||
|
|
||
| (b) You must cause any modified files to carry prominent notices | ||
| stating that You changed the files; and | ||
|
|
||
| (c) You must retain, in the Source form of any Derivative Works | ||
| that You distribute, all copyright, patent, trademark, and | ||
| attribution notices from the Source form of the Work, | ||
| excluding those notices that do not pertain to any part of | ||
| the Derivative Works; and | ||
|
|
||
| (d) If the Work includes a "NOTICE" text file as part of its | ||
| distribution, then any Derivative Works that You distribute must | ||
| include a readable copy of the attribution notices contained | ||
| within such NOTICE file, excluding those notices that do not | ||
| pertain to any part of the Derivative Works, in at least one | ||
| of the following places: within a NOTICE text file distributed | ||
| as part of the Derivative Works; within the Source form or | ||
| documentation, if provided along with the Derivative Works; or, | ||
| within a display generated by the Derivative Works, if and | ||
| wherever such third-party notices normally appear. The contents | ||
| of the NOTICE file are for informational purposes only and | ||
| do not modify the License. You may add Your own attribution | ||
| notices within Derivative Works that You distribute, alongside | ||
| or as an addendum to the NOTICE text from the Work, provided | ||
| that such additional attribution notices cannot be construed | ||
| as modifying the License. | ||
|
|
||
| You may add Your own copyright statement to Your modifications and | ||
| may provide additional or different license terms and conditions | ||
| for use, reproduction, or distribution of Your modifications, or | ||
| for any such Derivative Works as a whole, provided Your use, | ||
| reproduction, and distribution of the Work otherwise complies with | ||
| the conditions stated in this License. | ||
|
|
||
| 5. Submission of Contributions. Unless You explicitly state otherwise, | ||
| any Contribution intentionally submitted for inclusion in the Work | ||
| by You to the Licensor shall be under the terms and conditions of | ||
| this License, without any additional terms or conditions. | ||
| Notwithstanding the above, nothing herein shall supersede or modify | ||
| the terms of any separate license agreement you may have executed | ||
| with Licensor regarding such Contributions. | ||
|
|
||
| 6. Trademarks. This License does not grant permission to use the trade | ||
| names, trademarks, service marks, or product names of the Licensor, | ||
| except as required for reasonable and customary use in describing the | ||
| origin of the Work and reproducing the content of the NOTICE file. | ||
|
|
||
| 7. Disclaimer of Warranty. Unless required by applicable law or | ||
| agreed to in writing, Licensor provides the Work (and each | ||
| Contributor provides its Contributions) on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| implied, including, without limitation, any warranties or conditions | ||
| of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A | ||
| PARTICULAR PURPOSE. You are solely responsible for determining the | ||
| appropriateness of using or redistributing the Work and assume any | ||
| risks associated with Your exercise of permissions under this License. | ||
|
|
||
| 8. Limitation of Liability. In no event and under no legal theory, | ||
| whether in tort (including negligence), contract, or otherwise, | ||
| unless required by applicable law (such as deliberate and grossly | ||
| negligent acts) or agreed to in writing, shall any Contributor be | ||
| liable to You for damages, including any direct, indirect, special, | ||
| incidental, or consequential damages of any character arising as a | ||
| result of this License or out of the use or inability to use the | ||
| Work (including but not limited to damages for loss of goodwill, | ||
| work stoppage, computer failure or malfunction, or any and all | ||
| other commercial damages or losses), even if such Contributor | ||
| has been advised of the possibility of such damages. | ||
|
|
||
| 9. Accepting Warranty or Additional Liability. While redistributing | ||
| the Work or Derivative Works thereof, You may choose to offer, | ||
| and charge a fee for, acceptance of support, warranty, indemnity, | ||
| or other liability obligations and/or rights consistent with this | ||
| License. However, in accepting such obligations, You may act only | ||
| on Your own behalf and on Your sole responsibility, not on behalf | ||
| of any other Contributor, and only if You agree to indemnify, | ||
| defend, and hold each Contributor harmless for any liability | ||
| incurred by, or claims asserted against, such Contributor by reason | ||
| of your accepting any such warranty or additional liability. | ||
|
|
||
| END OF TERMS AND CONDITIONS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| MIT License | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Bevy Solari | ||
|
|
||
| [](https://github.com/bevyengine/bevy#license) | ||
| [](https://crates.io/crates/bevy_solari) | ||
| [](https://crates.io/crates/bevy_solari) | ||
| [](https://docs.rs/bevy_solari/latest/bevy_solari/) | ||
| [](https://discord.gg/bevy) | ||
|
|
||
|  |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #![expect(missing_docs, reason = "Not all docs are written yet, see #3492.")] | ||
|
|
||
| //! Provides raytraced lighting. | ||
cart marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| //! | ||
| //!  | ||
| pub mod pathtracer; | ||
| pub mod scene; | ||
|
|
||
| /// The solari prelude. | ||
| /// | ||
| /// This includes the most common types in this crate, re-exported for your convenience. | ||
| pub mod prelude { | ||
| pub use super::SolariPlugin; | ||
| pub use crate::pathtracer::Pathtracer; | ||
| pub use crate::scene::RaytracingMesh3d; | ||
| } | ||
|
|
||
| use bevy_app::{App, Plugin}; | ||
| use bevy_render::settings::WgpuFeatures; | ||
| use pathtracer::PathtracingPlugin; | ||
| use scene::RaytracingScenePlugin; | ||
|
|
||
| pub struct SolariPlugin; | ||
|
|
||
| impl Plugin for SolariPlugin { | ||
| fn build(&self, app: &mut App) { | ||
| app.add_plugins((RaytracingScenePlugin, PathtracingPlugin)); | ||
| } | ||
| } | ||
|
|
||
| impl SolariPlugin { | ||
| /// [`WgpuFeatures`] required for this plugin to function. | ||
| pub fn required_wgpu_features() -> WgpuFeatures { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (unrelated) we're really overdue for structured plugins. this is the kind of thing that should be centralized by a trait and collected at initialization to request the minimal feature set. |
||
| WgpuFeatures::EXPERIMENTAL_RAY_TRACING_ACCELERATION_STRUCTURE | ||
| | WgpuFeatures::EXPERIMENTAL_RAY_QUERY | ||
| | WgpuFeatures::BUFFER_BINDING_ARRAY | ||
| | WgpuFeatures::TEXTURE_BINDING_ARRAY | ||
| | WgpuFeatures::UNIFORM_BUFFER_AND_STORAGE_TEXTURE_ARRAY_NON_UNIFORM_INDEXING | ||
| | WgpuFeatures::SAMPLED_TEXTURE_AND_STORAGE_BUFFER_ARRAY_NON_UNIFORM_INDEXING | ||
| | WgpuFeatures::PARTIALLY_BOUND_BINDING_ARRAY | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this being true mean its building a BLAS for all meshes even when bevy_solari is not in use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about instead, defaulting to false, and having a method on Mesh which checks the set of vertex attributes is {{POSITION, NORMAL, UV_0, TANGENT}} before setting the bool to true, and returns an error otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends by what you mean by "not in use". If the solari scene plugin is added to the app, your GPU supports RT, and the mesh is compatible and has enable_raytracing: true, then yes the mesh will get a BLAS built.
If the plugin is not loaded (it's not part of default apps) / your GPU does not support RT, or the mesh is not compatible or has RT off, then no a BLAS won't be built.
The raytracing_enabled field is not meant to be "whether or not the mesh is compatible for RT". The field is meant for cases where you don't want to build a BLAS for a mesh even if it's compatible. E.g. for higher level LODs if you're using exclusively lower level LODs for RT to reduce BLAS and traversal cost. I'll update the docs to make this explicit.