Skip to content

Don't unnecesarily enable reflection in bevy_render by removing the default feature of bevy_render#23667

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Zeophlite:no-default-render
Apr 5, 2026
Merged

Don't unnecesarily enable reflection in bevy_render by removing the default feature of bevy_render#23667
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Zeophlite:no-default-render

Conversation

@Zeophlite
Copy link
Copy Markdown
Contributor

@Zeophlite Zeophlite commented Apr 5, 2026

Objective

Solution

  • Remove it

Testing

  • CI
  • cargo run --example server --features="bevy_remote" + curl -d'{"jsonrpc":"2.0","method":"schedule.graph","id":1,"params":{"schedule_label":"Render"}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15703 still works

@Zeophlite Zeophlite requested a review from Shatur April 5, 2026 01:27
@Zeophlite Zeophlite added A-Rendering Drawing game state to the screen A-Reflection Runtime information about types D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 5, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Apr 5, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Reflection Apr 5, 2026
@Zeophlite Zeophlite added this to the 0.19 milestone Apr 5, 2026
@Zeophlite Zeophlite mentioned this pull request Apr 5, 2026
@alice-i-cecile alice-i-cecile changed the title Remove default Don't unnecesarily enable reflection in bevy_render by removing the default feature of bevy_render Apr 5, 2026
@alice-i-cecile alice-i-cecile requested a review from atlv24 April 5, 2026 01:37
@alice-i-cecile alice-i-cecile added the X-Uncontroversial This work is generally agreed upon label Apr 5, 2026
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 5, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 5, 2026
Merged via the queue into bevyengine:main with commit 1a48b3f Apr 5, 2026
55 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Reflection Apr 5, 2026
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Reflection Runtime information about types A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants