Process GeneratedEnvironmentMapLight on-demand#24522
Open
dylansechet wants to merge 3 commits into
Open
Conversation
Contributor
|
I generally like the solution, but I don't know if we should make this opt in, as in, always update by default. Or at least offer some automatic ways to update it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
GeneratedEnvironmentMapLightcurrently does work every frame converting a cubemap into an environment map, which can be performance heavy (#24517). This PR makes this conversion happen on demand instead.This addresses the first item in #20212.
Solution
GeneratedEnvironmentMapLightnow exposes aregenerateboolean field, which is reset during extraction. This copies the behavior of TAA'sresetfield.However, the boolean isn't quite enough: if the pipelines/assets aren't ready on the frame when
regenerateis set totrue, nothing runs and you end up with a black env map. To ensure we retry to process the env map until the filtering has actually run, I've created a render world component calledRegenerateEnvironmentMapwhich only gets removed once the filtering has actually run.Testing
reflection_probesandatmosphereexamplesOn the
reflection_probesexample, current PR in yellow and main in red. This was run on a noisy laptop, so should probably be taken with a pinch of salt: