bsn: support field name shorthand#24526
Open
cart wants to merge 1 commit into
Open
Conversation
alice-i-cecile
approved these changes
Jun 4, 2026
kfc35
approved these changes
Jun 6, 2026
Contributor
kfc35
left a comment
There was a problem hiding this comment.
looks good to me, have to resolve conflicts
ickshonpe
reviewed
Jun 6, 2026
Contributor
There was a problem hiding this comment.
The code generation doesn't match the equivalent explicit version, suppose value is a u32 field:
let value = 10u8;
bsn! {
Foo { value: value }
}works because it adds an into() but not with:
let value = 10u8;
bsn! {
Foo { value }
}which results in a type mismatch error.
Member
|
This should be added to docs (at least the syntax table) once #24464 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bsn!should support Rust's "name shorthand syntax":Solution
Add support, both for normal types and "props":
This also changes generated internal bsn! variables to use
__Xformatting everywhere to avoid conflicts with user-defined variables (we were already using this strategy in some places ... this just uses it everywhere).Testing