Skip to content

use sort_unstable if you're deduplicating anyways #24545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miguelraz wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

use sort_unstable if you're deduplicating anyways #24545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/bevy_ecs/src/entity/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,7 @@ mod tests {
}

let pre_len = entities.len();
entities.sort();
entities.sort_unstable();
entities.dedup();
assert_eq!(pre_len, entities.len());

Expand All @@ -1516,7 +1516,7 @@ mod tests {

entities.extend(allocator.alloc_many(5000));
let pre_len = entities.len();
entities.sort();
entities.sort_unstable();
entities.dedup();
assert_eq!(pre_len, entities.len());
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_math/src/curve/cores.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ impl<T> ChunkedUnevenCore<T> {
fn filter_sort_dedup_times(times: impl IntoIterator<Item = f32>) -> Vec<f32> {
// Filter before sorting/deduplication so that NAN doesn't interfere with them.
let mut times = times.into_iter().filter(|t| t.is_finite()).collect_vec();
times.sort_by(f32::total_cmp);
times.sort_unstable_by(f32::total_cmp);
times.dedup();
times
}
Expand Down
4 changes: 2 additions & 2 deletions crates/bevy_math/src/curve/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ pub trait CurveResampleExt<T>: Curve<T> {
.into_iter()
.filter(|t| t.is_finite() && domain.contains(*t))
.collect_vec();
times.sort_by(f32::total_cmp);
times.sort_unstable_by(f32::total_cmp);
times.dedup();
if times.len() < 2 {
return Err(ResamplingError::NotEnoughSamples(times.len()));
Expand Down Expand Up @@ -914,7 +914,7 @@ pub trait CurveResampleExt<T>: Curve<T> {
.into_iter()
.filter(|t| t.is_finite() && domain.contains(*t))
.collect_vec();
times.sort_by(f32::total_cmp);
times.sort_unstable_by(f32::total_cmp);
times.dedup();
if times.len() < 2 {
return Err(ResamplingError::NotEnoughSamples(times.len()));
Expand Down
Loading