Skip to content

even more .sort_unstable + .dedup() combos#24547

Open
miguelraz wants to merge 1 commit into
bevyengine:mainfrom
miguelraz:even-more-sort-unstable-dedupes
Open

even more .sort_unstable + .dedup() combos#24547
miguelraz wants to merge 1 commit into
bevyengine:mainfrom
miguelraz:even-more-sort-unstable-dedupes

Conversation

@miguelraz
Copy link
Copy Markdown

@miguelraz miguelraz commented Jun 7, 2026

Objective

Solution

  • If you're deduplicating anyways, might as well use the non-allocating unstable sort.

Testing

  • Did you test these changes? cargo test -p bevy_math, it passed!

Showcase

I think I'll benchmark both of these PRs together since they both improve on the curve crate of bevy_math.

@ChristopherBiscardi ChristopherBiscardi added A-Math Fundamental domain-agnostic mathematical operations S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 7, 2026
@alice-i-cecile alice-i-cecile added C-Performance A change motivated by improving speed, memory usage or compile times C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jun 7, 2026
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy and removed D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 7, 2026
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@amtep amtep amtep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miguelraz @amtep @alice-i-cecile @ChristopherBiscardi