Conversation
|
You have 268 files in this PR. Are all files used? |
The test-data folder has many files due to multiple test cases to check different functions. I’ll reduce it to one or two representative tests. However, even a single test produces around 50 output files — I’ll reduce them as much as possible. |
|
Do you check all these generated outputs? If a test generates 50 files to you check/diff all the 50 files? I can not see that in your PR |
Yes, you're right. Some outputs like alternate_bins_membership and alternate_bins_summary are collections with many files (e.g., 19 elements). I checked representative files (4 out of 19). But I’ve removed those outputs for now. |
|
You should only remove the file you are NOT checking. The files that are useless in this PR. Also consider to use |
|
Hi Saim, |
|
Hi @Minamehr, Sorry, I didn’t realize you were still actively working on the PR as it hadn’t seen much activity for a couple of weeks and wasn’t in draft, so when Bjoern asked me about it, I thought I could help move it forward by amending changes and merging. Totally fine to open a follow-up PR with the remaining changes. Also, maybe consider marking WIP PRs as draft next time so it’s clearer they’re still in progress. :) |
|
Hey, no worries at all — thanks for the follow-up and the tip! I’ll make sure to mark it as draft next time to avoid confusion. 😊 |
Hi – This pull request adds the tool vRhyme to the repository.
Thanks!