Skip to content

[circuits] swap_bytes_32 for reversing bytes in 32-bit words#901

Closed
jimpo wants to merge 1 commit intomainfrom
09-01-_circuits_swap_bytes_32_for_reversing_bytes_in_32-bit_words
Closed

[circuits] swap_bytes_32 for reversing bytes in 32-bit words#901
jimpo wants to merge 1 commit intomainfrom
09-01-_circuits_swap_bytes_32_for_reversing_bytes_in_32-bit_words

Conversation

@jimpo
Copy link
Copy Markdown
Collaborator

@jimpo jimpo commented Sep 1, 2025

No description provided.

Copy link
Copy Markdown
Collaborator Author

jimpo commented Sep 1, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Sep 1, 2025

Merge activity

  • Sep 1, 8:47 PM UTC: jimpo added this pull request to the Graphite merge queue.
  • Sep 1, 8:53 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Sep 1, 9:10 PM UTC: jimpo added this pull request to the Graphite merge queue.
  • Sep 1, 9:10 PM UTC: CI is running for this pull request on a draft pull request (#904) due to your merge queue CI optimization settings.
  • Sep 1, 9:17 PM UTC: Merged by the Graphite merge queue via draft PR: #904.

Copy link
Copy Markdown
Contributor

actually not clear to me what the point of extracting out swap_bytes_32 is. as far as i can see, no one calls that directly—it's only called by swap_bytes. is the point to use rotl, instead of bitshifting? but you could have done that without extracting the helper.

@graphite-app graphite-app bot changed the base branch from 09-01-_circuits_swap_bytes_circuit_gadget_builder to graphite-base/901 September 1, 2025 20:53
@graphite-app graphite-app bot force-pushed the 09-01-_circuits_swap_bytes_32_for_reversing_bytes_in_32-bit_words branch from 7fe8f57 to 09bf65a Compare September 1, 2025 20:54
@graphite-app graphite-app bot changed the base branch from graphite-base/901 to main September 1, 2025 20:54
@graphite-app graphite-app bot force-pushed the 09-01-_circuits_swap_bytes_32_for_reversing_bytes_in_32-bit_words branch from 09bf65a to c5c4e98 Compare September 1, 2025 20:54
Copy link
Copy Markdown
Collaborator Author

jimpo commented Sep 1, 2025

It's for sha256::message_to_le_wires

@graphite-app graphite-app bot closed this Sep 1, 2025
@graphite-app graphite-app bot deleted the 09-01-_circuits_swap_bytes_32_for_reversing_bytes_in_32-bit_words branch September 1, 2025 21:17
Copy link
Copy Markdown
Contributor

oh. my bad. missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants